test: deflake WASI poll timing checks - #65672
Open
panva wants to merge 1 commit into
Open
Conversation
panva
added
the
flaky-test
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Use a monotonic high-resolution clock for elapsed-time checks and allow a small tolerance for timer granularity. The previous whole-second clock could report an interval one second short when a slightly early timer coincided with a wall-clock boundary. Assisted-by: Codex Signed-off-by: Filip Skokan <panva.ip@gmail.com>
panva
force-pushed
the
fix-wasi-poll-timeout-flake
branch
from
August 30, 2026 18:09
349cac4 to
7c49367
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65672 +/- ##
==========================================
- Coverage 91.72% 90.06% -1.67%
==========================================
Files 402 754 +352
Lines 181167 255747 +74580
Branches 27812 48321 +20509
==========================================
+ Hits 166173 230330 +64157
- Misses 14653 16546 +1893
- Partials 341 8871 +8530 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a monotonic high-resolution clock for elapsed-time checks and allow a small tolerance for timer granularity. The previous whole-second clock could report an interval one second short when a slightly early timer coincided with a wall-clock boundary.