Conversation
The check prior to this refactoring in `org-transclusion-check-add` is intended to check also the line at point is in a block such as an example. This is cleverly taken care of by `org-element-at-point` -- it tells the element at point is a block, not a keyword.
read-number does not error when the user enters non-number value; instead it loops back to the prompt. `org-transclusion-menu-level` emulates it and loops back when the number entered is not between 1 and 9 (inclusive).
stardiviner
approved these changes
Apr 23, 2023
stardiviner
left a comment
stardiviner
left a comment
There was a problem hiding this comment.
I reviewed the code, this looks fine to me. Wait for second round feature of keybinding interface. What interface do you decide to use? transicient? which-key? hydra?
|
Seems using which-key as interface is the simplest way, it only need to define a keymap prefix. Then define all commands keybindings under this prefix so that which-key can show those commands. Transient is the best UI which supports suffix, prefix etc. Which it will support modify and see the instant change as awesome as Magit. Also can support future features may requires complex operations. (So I suggest to use transient.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explore UX improvement for when adding additional properties to
#+transclude. See #169.The idea is simple and goes like this:
This way, the underlying menu does not have to be constructed via Hydra. I guess it can be Transient, Which-key, or the built-in menu system.