Repository navigation
fix: apply filters only to fieldmaps - #563
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## maint/2.15.x #563 +/- ##
=============================================
Coverage 84.13% 84.14%
=============================================
Files 30 30
Lines 2875 2876 +1
Branches 382 382
=============================================
+ Hits 2419 2420 +1
Misses 381 381
Partials 75 75 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
effigies
approved these changes
Oct 2, 2026
mgxd
added a commit
that referenced
this pull request
Oct 2, 2026
2.15.2 (October 2, 2026)
Patch release in the 2.15.x series.
This includes two fixes for fieldmap-less estimation:
- In multi-session datasets, a subject-level anatomical reference (i.e., without
a ``session`` entity) was not found for session-specific EPI data.
A session-matched anatomical image is still preferred when available.
- ``bids_filters`` intended for fieldmaps (e.g., ``{"datatype": "fmap"}``) were also
applied when searching for the anatomical reference and EPI targets, silently
preventing fieldmap-less estimation (nipreps/fmriprep#3632).
It also fixes the PEPOLAR heuristics ignoring ``acquisition`` filters, and
finding no estimators when filtering on a single ``ceagent``.
* FIX: Do not apply fieldmap filters to fieldmap-less queries (#563)
* FIX: Allow sessionless anatomical references for fieldmap-less estimation (#562)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find_estimatorsapplied the flatbids_filtersdict to every query, including the anatomical reference and EPI targets for fieldmap-less estimation. This changes filters to just apply to fieldmap queries - in the future, it may be worthwhile to allow per-query filtering.Also fixes
acquisitionextraction andacq/ceagentpotentially splitting into chars.