Skip to content

rf: Split premask workflow out of enhance_and_skullstrip_wf - #1001

Merged
effigies merged 2 commits into
nipreps:masterfrom
effigies:rf/premask
Oct 2, 2026
Merged

effigies merged 2 commits into
nipreps:masterfrom
effigies:rf/premask

Conversation

@effigies

Copy link
Copy Markdown
Member

Begins to address #1000. This will allow fmriprep to generate its pre-mask from its HMC boldref while enhancing and skull-stripping the sbref, if provided.

effigies added a commit to effigies/fmriprep that referenced this pull request Nov 26, 2025
effigies added a commit to effigies/fmriprep that referenced this pull request Nov 26, 2025
@codecov

codecov Bot commented Nov 26, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 5.88235% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.13%. Comparing base (b89c090) to head (2d7c982).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
niworkflows/func/util.py 5.88% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1001      +/-   ##
==========================================
- Coverage   67.18%   67.13%   -0.06%     
==========================================
  Files          54       54              
  Lines        6848     6855       +7     
  Branches      849      849              
==========================================
+ Hits         4601     4602       +1     
- Misses       2034     2040       +6     
  Partials      213      213              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mgxd mgxd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, minor nit

Comment thread niworkflows/func/util.py Resolved
Co-authored-by: Mathias Goncalves <goncalves.mathias@gmail.com>
@effigies
effigies merged commit 6326c6c into nipreps:master Oct 2, 2026
5 of 8 checks passed
@effigies
effigies deleted the rf/premask branch October 2, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants