Skip to content

feat: sdk 26–27 compat, bn254 module, contractimpl findings, vendored publishable attr stack #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
willemneal wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: sdk 26–27 compat, bn254 module, contractimpl findings, vendored publishable attr stack #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
72d0679
fix: track the soroban-sdk 26 line with a caret req
willemneal Aug 17, 2026
dfb1b19
feat: bn254 module + sdk 26-27 compat range
willemneal Aug 17, 2026
e7af29a
feat(probe): contractimpl inline-spec probe — sdk patch obsolete, dis…
willemneal Aug 17, 2026
3170467
feat: vendor the flux attribute stack — every crate now crates.io-pub…
willemneal Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@ jobs:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
- uses: Swatinem/rust-cache@v2
- run: cargo fmt --all --check
- run: cargo clippy --workspace --all-targets -- -D warnings
# fmt/clippy scope excludes the byte-identical vendored flux crates
# (crates/soroban-flux-attrs-impl/VENDORED.md).
- run: cargo fmt -p soroban-flux -p probe-sdk26 --check
- run: cargo clippy --workspace --all-targets
- run: cargo test --workspace

# The verification gate: cargo flux over every flux-enabled crate.
Expand Down
15 changes: 14 additions & 1 deletion COMPATIBILITY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ bump here first, burn in, then roll out.

| soroban-flux | flux rev | nightly | soroban-sdk | z3 | fixpoint | status |
|---|---|---|---|---|---|---|
| 0.1.0-dev | `283ad73` (2026-08-17) | nightly-2026-02-05 | =26.0.1 | 5.0.0 | nightly (2026-08) | **M0 GO** (2026-08-17) |
| 0.1.0-dev | `283ad73` (2026-08-17) | nightly-2026-02-05 | =26.0.1 | 5.0.0 | nightly (2026-08) | **M0 GO**; attrs vendored (publishable) 2026-08-17 |

## M0 probe log (2026-08-17) — GO

Expand Down Expand Up @@ -41,3 +41,16 @@ All three probes green; whole run sub-second warm, ~25 s cold (dep compile).
5. `extern_spec` impl blocks must mirror the SDK's *block structure*, not just
signatures: `Vec::new`/`push_back` live in the `T: IntoVal + TryFromVal`
block, `len` in a separate unbounded `impl<T> Vec<T>`.

## contractimpl inline-annotation findings (2026-08-17, probe 4)

- The 2024 flux-rs sdk-fork patch (`filter_out_flux_attrs`) is **obsolete**:
soroban-sdk 25+ strips all non-doc/cfg/allow/deny attributes from
macro-generated code via `pass_through_attr_to_gen_code`, so `flux_tool::*`
attrs never reach generated copies. Inline `#[sig]` on `#[contractimpl]`
methods works without any sdk patch.
- The generated dispatcher (`__Ty__fn__invoke_raw`) is flux-checked **as a
caller** of the annotated method: input refinements on public entry points
are rejected as unprovable preconditions (the host can pass anything).
Correct pattern: entry points validate at the boundary and carry
postconditions; rich preconditions live on the internal macro-free layer.
Loading
Loading