feat: Add updatedAt support for orderBy and projection in query specs

[Ahalya-ni]

Summary

Adds UPDATED_AT as a supported value for order_by and projection in QuerySpecificationsRequest, consistent with the server-side changes made in the Skyline repo.

Pull Request 1293910: Specification Management | Add updatedAt field to order by options in /query-specs
Technical Debt 4025900: Specs Service Python client | Add UpdatedAt support for query specs

Changes

• SpecificationOrderBy: Added UPDATED_AT enum value, allowing specs to be sorted by last modification time.
• SpecificationProjection: Added UPDATED_AT enum value, allowing updatedAt to be requested as a projected field (consistent with CREATED_AT).
• models/__init__.py: Exported SpecificationOrderBy so it is importable from nisystemlink.clients.spec.models.

Tests

Added integration tests in tests/integration/spec/test_spec.py:

• Ascending updatedAt ordering — creates two specs, updates one, and verifies the unmodified spec (older updated_at) comes first.
• Descending updatedAt ordering — same setup, verifies the updated spec (newer updated_at) comes first.
• UPDATED_AT projection — added UPDATED_AT to the existing test__query_spec_projection_columns__columns_returned test alongside SPEC_ID and NAME, verifying all three fields are returned.

[Copilot]

Pull request overview

This PR updates the Specification (spec) client models to support UPDATED_AT in QuerySpecificationsRequest for both order_by and projection, aligning the Python client with the server-side “query-specs” API capabilities.

Changes:

• Added UPDATED_AT to SpecificationOrderBy and SpecificationProjection enums used by QuerySpecificationsRequest.
• Exported SpecificationOrderBy from nisystemlink.clients.spec.models for public import.
• Added integration tests covering ordering by updatedAt (ascending/descending) and projecting only updatedAt.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
tests/integration/spec/test_spec.py	Adds integration coverage for UPDATED_AT ordering and projection behavior.
nisystemlink/clients/spec/models/_query_specs.py	Extends query-spec enums to include UPDATED_AT for order-by and projection.
nisystemlink/clients/spec/models/__init__.py	Re-exports SpecificationOrderBy from the models package.

Suppressed comments (1)

tests/integration/spec/test_spec.py:440

• Same issue as the ascending-order test: filtering out None updated_at values can make this pass even when updated_at isn’t returned consistently. Assert the field exists for every spec before validating the descending sort order.

        updated_ats = [spec.updated_at for spec in response.specs if spec.updated_at]
        assert updated_ats == sorted(updated_ats, reverse=True)

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Suppressed comments (2)

tests/integration/spec/test_spec.py:333

• The projection assertion aggregates non-None keys across all returned specs (and uses vars(spec)), so it can pass even if only a subset of specs include updated_at. To make this test reliably validate projection behavior, assert per-spec using model_dump(exclude_unset=True) and ensure each spec includes exactly the projected fields (and that updated_at is present).

        response = client.query_specs(request)
        specs = [vars(spec) for spec in response.specs or []]
        spec_columns = {
            key for spec in specs for key in spec.keys() if spec[key] is not None
        }

tests/integration/spec/test_spec.py:495

• This test doesn't assert that the update call succeeded. If update_specs partially fails, the ordering assertions may become flaky or misleading. Capture and assert the update response (consistent with earlier tests in this file) before querying and asserting sort order.

        client.update_specs(
            UpdateSpecificationsRequest(
                specs=[
                    UpdateSpecificationsRequestObject(
                        id=spec_1.id,

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (3)

Previously missed (1) — in code that hasn't changed since the last review.

tests/integration/spec/test_spec.py:468

• This test assumes the queried specs are always at positions 0 and 1. If additional specs exist for the same product (e.g., due to test ordering or eventual cleanup), the test could fail or validate the wrong items. Make the assertion relative by checking the index ordering of the two created spec IDs within the returned list.

This issue also appears on line 519 of the same file.

        assert response.specs
        # spec_2 was not updated, so it has an earlier updated_at — must come first
        assert response.specs[0].spec_id == spec_2_id
        assert response.specs[1].spec_id == spec_1_id

tests/integration/spec/test_spec.py:522

• This test assumes the queried specs are always at positions 0 and 1. If additional specs exist for the same product (e.g., due to test ordering or eventual cleanup), the test could fail or validate the wrong items. Make the assertion relative by checking the index ordering of the two created spec IDs within the returned list.

        assert response.specs
        # spec_1 was updated last, so it has a later updated_at — must come first
        assert response.specs[0].spec_id == spec_1_id
        assert response.specs[1].spec_id == spec_2_id

tests/integration/spec/test_spec.py:333

• The projection assertion is brittle: it uses vars(spec) and unions non-None keys across all specs, so the test can still pass even if only a subset of returned specs includes updated_at (or if Pydantic internals appear in vars). Prefer model_dump(exclude_unset=True) and assert per-spec that only the projected fields are present.

        response = client.query_specs(request)
        specs = [vars(spec) for spec in response.specs or []]
        spec_columns = {
            key for spec in specs for key in spec.keys() if spec[key] is not None
        }