Skip to content

Force Storybook build publish #3051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rajsite wants to merge 2 commits into from
Closed

Force Storybook build publish #3051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f27e52
Align with angular optional label
rajsite Aug 30, 2026
403a47f
Enable forceRebuild
rajsite Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ jobs:
storybookBaseDir: ./packages/storybook
exitOnceUploaded: true # Do not wait for test results
exitZeroOnChanges: true # Option to prevent the workflow from failing
forceRebuild: true # Always publish build so example app only changes are pushed

# Validate (Lint and Test)
- run: npm run validate
Expand Down
2 changes: 1 addition & 1 deletion packages/react-workspace/react-client-app/src/components/OverviewSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { SubContainer } from './SubContainer';

export function OverviewSection(): React.JSX.Element {
return (
<SubContainer label="Overview">
<SubContainer>
Explore the components below to see the Nimble components in action.
See the <NimbleAnchor href="https://nimble.ni.dev/storybook/">Nimble component docs</NimbleAnchor> for additional usage details.
Navigate to the <NimbleAnchor href="../index.html">parent page</NimbleAnchor>.
Expand Down
4 changes: 2 additions & 2 deletions packages/react-workspace/react-client-app/src/components/SubContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
import type { ReactNode } from 'react';

interface SubContainerProp {
label: string;
label?: string;
children?: ReactNode;
}

export function SubContainer({ label, children }: SubContainerProp): React.JSX.Element {
return (
<>
<div className="sub-container">
<div className="container-label">{label}</div>
{label && <div className="container-label">{label}</div>}
<div>{children}</div>
</div>
</>
Expand Down