Skip to content

Improve Spright chat message sizing for wide content #3038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jattasNI wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Improve Spright chat message sizing for wide content #3038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d63861e
max-width on host, don't need calc, need align self
jattasNI Aug 20, 2026
befca29
max-width on .message-content
jattasNI Aug 20, 2026
1cccb87
Change files
jattasNI Aug 20, 2026
eef2bc9
Merge branch 'main' into chat-message-sizing
jattasNI Aug 26, 2026
1c297fa
Container width grows with message
jattasNI Aug 26, 2026
ddb4e07
Revert changes to deprecated message
jattasNI Aug 26, 2026
7fbd9c7
inbound max width 100%
jattasNI Aug 26, 2026
f564c06
Make message longer to keep test cases working
jattasNI Aug 26, 2026
bb0523b
Merge branch 'main' into chat-message-sizing
jattasNI Aug 26, 2026
129bb26
Fix positioning in message matrix story
jattasNI Aug 26, 2026
9d71f81
Merge branch 'main' into chat-message-sizing
jattasNI Aug 26, 2026
b160e25
Merge branch 'main' into chat-message-sizing
rajsite Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@ni-spright-components-53dfedf2-8550-49e2-816e-5988e14affad.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
Comment thread
jattasNI marked this conversation as resolved.

@rajsite rajsite Aug 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message scrollbars in Windows Chrome clip the border of messages a bit (went in devtools and removed the outline that the story itself adds for the screenshot):

Image

@jattasNI jattasNI Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what to do here and I'm open to inputs from regular Windows users about what would feel natural. On mac the overlay scrollbars tend to be translucent and not permanently visible so I'm not sure what typical conventions are for cases like this.

Some options:

  1. do nothing because, at the moment, outbound messages are the only ones with a border/background and all clients currently only populate them with text content which wraps rather than overflows
  2. inset the scrollbar something like in the screenshot below. I achieved this by moving the border/background rendering to the outer container, keeping the scrollbar on the inner content, and adding padding between them.
  3. other ideas?
image

"type": "patch",
"comment": "Chat message sizing is more client configurable",
"packageName": "@ni/spright-components",
"email": "jattasNI@users.noreply.github.com",
"dependentChangeType": "patch"
}
5 changes: 4 additions & 1 deletion packages/spright-components/src/chat/message/inbound/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,11 @@ export const styles = css`
:host {
min-width: ${standardPadding};
min-height: ${standardPadding};
max-width: 100%;

flex-direction: row;
justify-content: flex-start;
align-self: flex-start;
flex-shrink: 0;
font: ${bodyFont};
color: ${bodyFontColor};
Expand All @@ -31,7 +33,7 @@ export const styles = css`
.container {
display: flex;
flex-direction: column;
max-width: calc(90%);
width: 100%;
}

[part='start'] {
Expand All @@ -41,6 +43,7 @@ export const styles = css`
.message-content {
width: fit-content;
height: fit-content;
max-width: 100%;
overflow-x: auto;
}

Expand Down
5 changes: 4 additions & 1 deletion packages/spright-components/src/chat/message/outbound/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,11 @@ export const styles = css`
:host {
min-width: ${standardPadding};
min-height: ${standardPadding};
max-width: 90%;

flex-direction: row;
justify-content: flex-end;
align-self: flex-end;
flex-shrink: 0;
font: ${bodyFont};
color: ${bodyFontColor};
Expand All @@ -28,12 +30,13 @@ export const styles = css`
.container {
display: flex;
flex-direction: column;
max-width: calc(90%);
width: 100%;
}

.message-content {
width: fit-content;
height: fit-content;
max-width: 100%;
overflow-x: auto;
}

Expand Down
5 changes: 4 additions & 1 deletion packages/spright-components/src/chat/message/system/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,11 @@ export const styles = css`
:host {
min-width: ${standardPadding};
min-height: ${standardPadding};
max-width: 90%;

flex-direction: row;
justify-content: center;
align-self: center;
flex-shrink: 0;
font: ${bodyFont};
color: ${bodyFontColor};
Expand All @@ -24,12 +26,13 @@ export const styles = css`
.container {
display: flex;
flex-direction: column;
max-width: calc(90%);
width: 100%;
}

.message-content {
width: fit-content;
height: fit-content;
max-width: 100%;
overflow-x: auto;
}
`;
4 changes: 3 additions & 1 deletion packages/spright-components/src/chat/message/welcome/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,12 @@ export const styles = css`
:host {
min-width: ${standardPadding};
min-height: ${standardPadding};
max-width: 90%;

flex: 1;
flex-direction: row;
justify-content: center;
align-self: center;
align-items: center;
font: ${bodyFont};
color: ${bodyFontColor};
Expand All @@ -31,7 +33,6 @@ export const styles = css`
display: flex;
flex-direction: column;
align-items: center;
max-width: calc(90%);
gap: ${mediumPadding};
}

Expand Down Expand Up @@ -65,6 +66,7 @@ export const styles = css`
align-items: center;
width: fit-content;
height: fit-content;
max-width: 100%;
overflow-x: auto;
gap: ${mediumPadding};
}
Expand Down
20 changes: 10 additions & 10 deletions packages/storybook/src/spright/chat/conversation/chat-conversation-matrix.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,10 +353,10 @@ const conversationWithInput = (
height: ${height};
">
<${chatMessageInboundTag}>
<span>Conversation is ${heightLabel} than the height of the messages. Lorem ipsum dolor sit amet.</span>
<span>Conversation is ${heightLabel} than the height of the messages. Lorem ipsum dolor sit amet, consectetur adipiscing elit.</span>
</${chatMessageInboundTag}>
<${chatMessageOutboundTag} message-type="outbound">
<span>Conversation is ${heightLabel} than the height of the messages. Lorem ipsum dolor sit amet.</span>
<span>Conversation is ${heightLabel} than the height of the messages. Lorem ipsum dolor sit amet, consectetur adipiscing elit.</span>
</${chatMessageOutboundTag}>
<${chatInputTag} slot='input'></${chatInputTag}>
</${chatConversationTag}>
Expand All @@ -383,10 +383,10 @@ const conversationWithToolbar = (
</${buttonTag}>
</${toolbarTag}>
<${chatMessageInboundTag}>
<span>Conversation is ${heightLabel} than the height of the messages. Lorem ipsum dolor sit amet.</span>
<span>Conversation is ${heightLabel} than the height of the messages. Lorem ipsum dolor sit amet, consectetur adipiscing elit.</span>
</${chatMessageInboundTag}>
<${chatMessageOutboundTag} message-type="outbound">
<span>Conversation is ${heightLabel} than the height of the messages. Lorem ipsum dolor sit amet.</span>
<span>Conversation is ${heightLabel} than the height of the messages. Lorem ipsum dolor sit amet, consectetur adipiscing elit.</span>
</${chatMessageOutboundTag}>
<${chatInputTag} slot='input'></${chatInputTag}>
</${chatConversationTag}>
Expand All @@ -410,10 +410,10 @@ const conversationWithStart = (
This is a banner in the start slot.
</${bannerTag}>
<${chatMessageInboundTag}>
<span>Conversation is ${heightLabel} than the height of the messages. Lorem ipsum dolor sit amet.</span>
<span>Conversation is ${heightLabel} than the height of the messages. Lorem ipsum dolor sit amet, consectetur adipiscing elit.</span>
</${chatMessageInboundTag}>
<${chatMessageOutboundTag} message-type="outbound">
<span>Conversation is ${heightLabel} than the height of the messages. Lorem ipsum dolor sit amet.</span>
<span>Conversation is ${heightLabel} than the height of the messages. Lorem ipsum dolor sit amet, consectetur adipiscing elit.</span>
</${chatMessageOutboundTag}>
<${chatInputTag} slot='input'></${chatInputTag}>
</${chatConversationTag}>
Expand Down Expand Up @@ -444,10 +444,10 @@ const conversationWithToolbarAndStart = (
This is a banner in the start slot.
</${bannerTag}>
<${chatMessageInboundTag}>
<span>Conversation is ${heightLabel} than the height of the messages. Lorem ipsum dolor sit amet.</span>
<span>Conversation is ${heightLabel} than the height of the messages. Lorem ipsum dolor sit amet, consectetur adipiscing elit.</span>
</${chatMessageInboundTag}>
<${chatMessageOutboundTag} message-type="outbound">
<span>Conversation is ${heightLabel} than the height of the messages. Lorem ipsum dolor sit amet.</span>
<span>Conversation is ${heightLabel} than the height of the messages. Lorem ipsum dolor sit amet, consectetur adipiscing elit.</span>
</${chatMessageOutboundTag}>
<${chatInputTag} slot='input'></${chatInputTag}>
</${chatConversationTag}>
Expand Down Expand Up @@ -478,10 +478,10 @@ const conversationWithToolbarAndStartAndEnd = (
This is a banner in the start slot.
</${bannerTag}>
<${chatMessageInboundTag}>
<span>Conversation is ${heightLabel} than the height of the messages. Lorem ipsum dolor sit amet.</span>
<span>Conversation is ${heightLabel} than the height of the messages. Lorem ipsum dolor sit amet, consectetur adipiscing elit.</span>
</${chatMessageInboundTag}>
<${chatMessageOutboundTag} message-type="outbound">
<span>Conversation is ${heightLabel} than the height of the messages. Lorem ipsum dolor sit amet.</span>
<span>Conversation is ${heightLabel} than the height of the messages. Lorem ipsum dolor sit amet, consectetur adipiscing elit.</span>
</${chatMessageOutboundTag}>
<${chatInputTag} slot='input'></${chatInputTag}>
<span slot='end'>
Expand Down
41 changes: 31 additions & 10 deletions packages/storybook/src/spright/chat/message/chat-message-matrix.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type { StoryFn, Meta } from '@storybook/html-vite';
import { html } from '@ni/fast-element';
import { chatConversationTag } from '@ni/spright-components/dist/esm/chat/conversation';
import { chatMessageTag } from '@ni/spright-components/dist/esm/chat/message';
import { chatMessageInboundTag } from '@ni/spright-components/dist/esm/chat/message/inbound';
import { chatMessageOutboundTag } from '@ni/spright-components/dist/esm/chat/message/outbound';
Expand All @@ -24,60 +25,80 @@ export default metadata;

export const messageHidden: StoryFn = createStory(
hiddenWrapper(
html`<${chatMessageTag} hidden>Hidden Chat Message</${chatMessageTag}>`
html`<${chatConversationTag}>
<${chatMessageTag} hidden>Hidden Chat Message</${chatMessageTag}>
</${chatConversationTag}>`
)
);

export const messageTextCustomized: StoryFn = createMatrixThemeStory(
textCustomizationWrapper(
html`<${chatMessageTag}>Message</${chatMessageTag}>`
html`<${chatConversationTag}>
<${chatMessageTag}>Message</${chatMessageTag}>
</${chatConversationTag}>`
)
);

export const messageInboundHidden: StoryFn = createStory(
hiddenWrapper(
html`<${chatMessageInboundTag} hidden>Hidden Chat Inbound Message</${chatMessageInboundTag}>`
html`<${chatConversationTag}>
<${chatMessageInboundTag} hidden>Hidden Chat Inbound Message</${chatMessageInboundTag}>
</${chatConversationTag}>`
)
);

export const messageInboundTextCustomized: StoryFn = createMatrixThemeStory(
textCustomizationWrapper(
html`<${chatMessageInboundTag}>Inbound Message</${chatMessageInboundTag}>`
html`<${chatConversationTag}>
<${chatMessageInboundTag}>Inbound Message</${chatMessageInboundTag}>
</${chatConversationTag}>`
)
);

export const messageOutboundHidden: StoryFn = createStory(
hiddenWrapper(
html`<${chatMessageOutboundTag} hidden>Hidden Chat Outbound Message</${chatMessageOutboundTag}>`
html`<${chatConversationTag}>
<${chatMessageOutboundTag} hidden>Hidden Chat Outbound Message</${chatMessageOutboundTag}>
</${chatConversationTag}>`
)
);

export const messageOutboundTextCustomized: StoryFn = createMatrixThemeStory(
textCustomizationWrapper(
html`<${chatMessageOutboundTag}>Outbound Message</${chatMessageOutboundTag}>`
html`<${chatConversationTag}>
<${chatMessageOutboundTag}>Outbound Message</${chatMessageOutboundTag}>
</${chatConversationTag}>`
)
);

export const messageSystemHidden: StoryFn = createStory(
hiddenWrapper(
html`<${chatMessageSystemTag} hidden>Hidden Chat System Message</${chatMessageSystemTag}>`
html`<${chatConversationTag}>
<${chatMessageSystemTag} hidden>Hidden Chat System Message</${chatMessageSystemTag}>
</${chatConversationTag}>`
)
);

export const messageSystemTextCustomized: StoryFn = createMatrixThemeStory(
textCustomizationWrapper(
html`<${chatMessageSystemTag}>System Message</${chatMessageSystemTag}>`
html`<${chatConversationTag}>
<${chatMessageSystemTag}>System Message</${chatMessageSystemTag}>
</${chatConversationTag}>`
)
);

export const messageWelcomeHidden: StoryFn = createStory(
hiddenWrapper(
html`<${chatMessageWelcomeTag} hidden welcome-title="Welcome" subtitle="Get started">Hidden Chat Welcome Message</${chatMessageWelcomeTag}>`
html`<${chatConversationTag}>
<${chatMessageWelcomeTag} hidden welcome-title="Welcome" subtitle="Get started">Hidden Chat Welcome Message</${chatMessageWelcomeTag}>
</${chatConversationTag}>`
)
);

export const messageWelcomeTextCustomized: StoryFn = createMatrixThemeStory(
textCustomizationWrapper(
html`<${chatMessageWelcomeTag} welcome-title="Welcome" subtitle="Get started">Welcome Message</${chatMessageWelcomeTag}>`
html`<${chatConversationTag}>
<${chatMessageWelcomeTag} welcome-title="Welcome" subtitle="Get started">Welcome Message</${chatMessageWelcomeTag}>
</${chatConversationTag}>`
)
);