Skip to content

Do not check for iptables module. - #88

Open
amstewart wants to merge 2 commits into
ni:masterfrom
amstewart:dev/iptables-fix
Open

Do not check for iptables module.#88
amstewart wants to merge 2 commits into
ni:masterfrom
amstewart:dev/iptables-fix

Conversation

@amstewart

@amstewart amstewart commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Summary of Changes

The module pre-requisites checks include a check for the iptables
module. As of NILRT 26.8, iptables is no longer installed. And we do not
actually need it for SNAC. So drop the check.

Also make the warning message at the start of nilrt-snac configure a little more noticeable.

Justification

Checking EUID
Checking iptables
modprobe: FATAL: Module ip_tables not found in directory /lib/modules/6.18.37-rt6-g043b43c1079e
iptables v1.8.10 (legacy): can't initialize iptables table `filter': Table does not exist (do you need to insmod?)
Perhaps iptables or your kernel needs to be upgraded.
(  128) ERROR nilrt_snac.main: Failed to find ip_tables module.

AB#4007929
AB#4022655

Testing

  • Installed and ran this build on a NILRT 26.8 VM and confirmed that it no longer attempts to check for iptables.

Procedure

  • This PR: changes user-visible behavior, fixes a bug, or impacts the project's security profile; and so it includes a CHANGELOG note.
  • I certify that the contents of this pull request complies with the Developer Certificate of Origin.

Alex Stewart added 2 commits August 28, 2026 13:01
The module pre-requisites checks include a check for the iptables
module. As of NILRT 26.8, iptables is no longer installed. And we do not
actually need it for SNAC. So drop the check.

Signed-off-by: Alex Stewart <alex.stewart@emerson.com>
The current warning messages are formatted to look like python logging
warnings, which makes it somewhat easier to ignore. Instead, output it
as a specially-formatted warning text block that is more obviously a
message from the developers.

Signed-off-by: Alex Stewart <alex.stewart@emerson.com>
@amstewart
amstewart requested review from a team and AlexHearnNI as code owners August 28, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant