fwupd: enable UEFI capsule/PK plugins and conditional udisks2 - #1080
fwupd: enable UEFI capsule/PK plugins and conditional udisks2 #1080AshwinUjjwal wants to merge 1 commit into
Conversation
-Add a fwupd bbappend in meta-nilrt for x64 targets. -Enable plugin_uefi_capsule and plugin_uefi_pk through PACKAGECONFIG so capsule updates are built in. -Add conditional udisks2 runtime recommendation when polkit is enabled to support ESP discovery in fwupdtool. Signed-off-by: AshwinUjjwal <ashwinujjwal.bharti@emerson.com>
There was a problem hiding this comment.
🟡 Changes recommended
The udisks2 recommendation is not scoped to x64 even though the PR title/description state it should be conditional on x64.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Enables additional fwupd functionality for NI Linux RT, primarily targeting x64 systems by turning on UEFI capsule/PK plugins and improving ESP discovery support for fwupdtool.
Changes:
- Adds a
fwupd_%.bbappendto enableplugin_uefi_capsuleandplugin_uefi_pkviaPACKAGECONFIGonx64. - Adds a conditional runtime recommendation for
udisks2whenpolkitis present inDISTRO_FEATURES.
File summaries
| File | Description |
|---|---|
| recipes-bsp/fwupd/fwupd_%.bbappend | Enables UEFI capsule/PK plugins for x64 and conditionally recommends udisks2 for ESP discovery support. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
AshwinUjjwal
changed the title
There was a problem hiding this comment.
🔵 Needs a closer look
The new conditional udisks2 runtime recommendation is not scoped to x64 and can unintentionally add udisks2 to non-UEFI targets when polkit is enabled.
Review details
Suppressed comments (1)
recipes-bsp/fwupd/fwupd_%.bbappend:5
- The conditional
udisks2runtime recommendation is applied for all machines wheneverpolkitis inDISTRO_FEATURES. Since this bbappend only enables the UEFI capsule/PK plugins forx64, thisRRECOMMENDSshould also be scoped tox64to avoid pullingudisks2into non-UEFI targets (e.g., xilinx-zynq) when polkit is enabled.
# ESP mounting support for fwupdtool when polkit is enabled
RRECOMMENDS:${PN} += "${@bb.utils.contains('DISTRO_FEATURES', 'polkit', 'udisks2', '', d)}"
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
Did you also test BSI build and test just to make sure there are no build errors with the changes? If so, can you add the info in the testing section? |
| @@ -0,0 +1,5 @@ | |||
| # Enable UEFI capsule update support for NI Linux RT x64 targets | |||
There was a problem hiding this comment.
Did you verify that the capsule update (and the other issue reported in the bug) works as expected after the changes? If you have already verified it, then please mention in the testing section, otherwise I would suggest to verify that first.
Summary of Changes
-Add a fwupd bbappend in meta-nilrt .
-Enable plugin_uefi_capsule and plugin_uefi_pk through PACKAGECONFIG so capsule updates are built in.
-Add conditional udisks2 runtime recommendation when polkit is enabled to support ESP discovery in fwupdtool.
Justification
AB#4011535
Testing
TODO: Detail what testing has been done to ensure this submission meets requirements.
Procedure