Skip to content

Tests failures should fail pipeline stage #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jasonmreding wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Tests failures should fail pipeline stage #517

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
16bfa8f
Tests failures should fail pipeline stage.
jasonmreding Jun 12, 2026
8ed6bde
Fix examples:
jasonmreding Jun 15, 2026
cb1dd58
Update other test projects reentrancy and source only changes as well…
jasonmreding Jun 15, 2026
a70b98f
Update test runner script to include the test log from the LV CLI int…
jasonmreding Jun 15, 2026
018923e
Update test runner script to not log failed test results twice.
jasonmreding Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tests/run_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,10 @@ def run_all_tests():
run_result = run_test(test_runner_vi, os.path.join(test_directory, test))
# run_result will be None for PASSED tests
if(run_result != None):
failed_test_results += run_result
failed_test_results += run_result
if (failed_test_results != ""):
_logger.exception(failed_test_results)

@bkeryan bkeryan Jun 13, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that makes sense. _logger.exception takes a str but it expects to be called from an except block.
https://docs.python.org/3/library/logging.html#logging.Logger.exception

_logger.error(failed_test_results)
sys.exit(1)

def run_test(WrapperVI, testVI):
if os.path.exists(testVI):
Expand All @@ -39,7 +40,7 @@ def run_test(WrapperVI, testVI):
stderr=subprocess.PIPE,
shell=False)


try:
out, err = testResult.communicate(timeout=60) # TODO: find if this timeout can be eliminated
except subprocess.TimeoutExpired:
Expand Down
Loading