NXxas and NXxas_trans application definitions and required base classes - #1640
Open
mretegan wants to merge 40 commits into
Open
NXxas and NXxas_trans application definitions and required base classes#1640mretegan wants to merge 40 commits into
NXxas and NXxas_trans application definitions and required base classes#1640mretegan wants to merge 40 commits into
Conversation
This reverts commit 72d12a7.
Draft
Contributor
|
From Telco: This removes NXxas from application definitions which requires a vote and adds new content to contributed definitions, which doesn't require a vote. To me that means this should be split into two PRs, one removing old content and one adding new content to contributed definitions. Also your comment mentions removing NXxasproc, but I don't see that in this pull request? Out of curiosity, how close is this to being fully ready for adoption in the community? Finally, just verifying that the old NXxas is fully unused, so greatly changing its meaning won't affect a huge of amount of users/data, correct? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MR introduces a subset of the X-ray absorption application definitions that use the inheritance-based mechanism discussed in #1352 and XraySpectroscopy#7. Once validated, new MRs will be opened for the remaining classes, which are somewhat more complex.
The new/updated application definitions are:
NXxasis a generic application definition for X-ray absorption spectroscopy (XAS).NXxas_transis an application definition that specializesNXxasfor data acquired in transmission mode.The new classes will replace the current
NXxasandNXxasproc, as each of them is designed to hold both raw and processed data, i.e., no need to have separate definitions.One particularly is the use of
dataRankto allow for either 1D or 2D data. Currently this is only expressed in thedocof different fields, but @woutdenolf had a few suggestions on how this could also be validated (see XraySpectroscopy#7 (comment)).