Fix(embedded) : column order, sort, scrolls overlays, refresh, table … - #2868
Fix(embedded) : column order, sort, scrolls overlays, refresh, table …#2868taiebot wants to merge 1 commit into
Conversation
…height * Fix: column order for embedded table Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com> * fix(widget): use fresh store data for rows/columns in ContentReferenceWidget Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com> * Fix embed col order (#12) * Fix: column order for embedded table Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com> * fix(widget): use fresh store data for rows/columns in ContentReferenceWidget Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com> --------- Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com> * Embed scroll (#11) * Adjust height and z-index in ContentReferenceWidget (#7) Signed-off-by: taiebot <dedreuil@yahoo.fr> * Fix Change height of tables-content-widget to auto Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com> --------- Signed-off-by: taiebot <dedreuil@yahoo.fr> Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com> * Fix: enable sorting on ContentReferenceWidget Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com> * Fix watcher for localViewSetting with debug logging Added a watcher for localViewSetting to log changes for debugging purposes. Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com> * Fix Remove debug watcher for localViewSetting Removed temporary debug watcher for localViewSetting. Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com> * Fix again Refactor loadColumnsFromBE to improve column sorting logic and add comments for clarity. Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com> --------- Signed-off-by: taiebot <13300652+taiebot@users.noreply.github.com> Signed-off-by: taiebot <dedreuil@yahoo.fr>
| if (!this.dataStore) return | ||
| try { | ||
| if (this.isView) { | ||
| await this.dataStore.loadColumnsFromBE({ view: this.richObject }) |
There was a problem hiding this comment.
the reference provider (ContentReferenceHelper) never puts columnSettings on the rich object. So inside loadColumnsFromBE the meta-column append doesn't seem to do anything?
| @@ -285,8 +318,11 @@ export default { | |||
| .nc-table { | |||
| min-width: var(--widget-content-width); | |||
|
|
|||
| :where(.options.row) { | |||
| display: none; | |||
| :deep(.options.row) { | |||
| height: 0 !important; | |||
| overflow: hidden !important; | |||
| margin: 0 !important; | |||
| padding: 0 !important; | |||
There was a problem hiding this comment.
From your gif, i only see vertical scrolling. Did you test horizontal too?
| elementId: this.richObject.id, | ||
| rows: this.richObject.rows, | ||
| }) | ||
| return |
There was a problem hiding this comment.
why remove this early return? for a table embed this now runs loadRowsFromBE, which hits /apps/tables/row/table/{id} and returns the full row set, whereas the reference only embedded about 100 rows
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
2 participants
🖼️ Screenshots
View order
Widget order
a little gif sorry the first seconds are frozen
🏁 Checklist
/backport to stableX.X🤖 AI (if applicable)