Skip to content

Add notification for async import finished event - #2819

Open
luka-nextcloud wants to merge 3 commits into
mainfrom
add-async-import-notification
Open

Add notification for async import finished event#2819
luka-nextcloud wants to merge 3 commits into
mainfrom
add-async-import-notification

Conversation

@luka-nextcloud

@luka-nextcloud luka-nextcloud commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

馃弫 Checklist

  • 鉀戯笍 Tests (unit and/or integration) are included or not needed
  • 馃敊 Backport requests are created or not needed: /backport to stableX.X
  • 馃搮 Milestone is set
  • 馃尭 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@luka-nextcloud luka-nextcloud added enhancement New feature or request 3. to review Waiting for reviews labels Jul 17, 2026
@github-project-automation github-project-automation Bot moved this to 馃Л Planning evaluation (don't pick) in 馃摑 Productivity team Jul 17, 2026
@luka-nextcloud luka-nextcloud moved this from 馃Л Planning evaluation (don't pick) to 馃憖 In review in 馃摑 Productivity team Jul 17, 2026
@blizzz
blizzz requested a review from samin-z July 21, 2026 21:12
Comment thread lib/Notification/NotificationHelper.php
@luka-nextcloud
luka-nextcloud requested a review from enjeck July 28, 2026 16:40
@luka-nextcloud
luka-nextcloud force-pushed the add-async-import-notification branch 2 times, most recently from 70d4927 to 26de49d Compare August 3, 2026 09:57
Comment thread lib/Notification/NotificationHelper.php
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Luka Trovic <luka@nextcloud.com>
@luka-nextcloud
luka-nextcloud force-pushed the add-async-import-notification branch from 26de49d to 3a8ee0b Compare August 17, 2026 09:33
@luka-nextcloud
luka-nextcloud requested a review from samin-z August 17, 2026 09:33
@samin-z

samin-z commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

ok so what i mentioned is already covered, i only found two things which one is not regarding this pr but thought maybe worth mentioning, and the other one could useful:

  1. when import is done (specially if the import is very big) in the activity table per each row that is inserted there is a message which for this case can get a bit out of hand, but we can tackle that maybe in another task.

  2. worth mentioning, if the import fails for whatever reason there is no notifications, i created a table and imported a file, while the background job was starting i removed the file, but no notifications was returned for the import that it failed. i also tried it with removing the table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

Status: 馃憖 In review

Development

Successfully merging this pull request may close these issues.

Add asynchronous import notification

3 participants