Skip to content

fix(psalm): resolve remaining type issues flagged by Psalm 7 #14014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristophWurst merged 1 commit into from
Nov 2, 2026
+7 −3
Merged

fix(psalm): resolve remaining type issues flagged by Psalm 7 #14014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/Db/MessageMapper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,15 +338,16 @@ public function insertBulk(Account $account, Message ...$messages): void {
];
foreach ($recipientTypes as $type => $recipients) {
foreach ($recipients->iterate() as $recipient) {
if ($recipient->getEmail() === null) {
$recipientEmail = $recipient->getEmail();
if ($recipientEmail === null) {
// If for some reason the e-mail is not set we should ignore this entry
continue;
}

$qb2->setParameter('message_id', $message->getId(), IQueryBuilder::PARAM_INT);
$qb2->setParameter('type', $type, IQueryBuilder::PARAM_INT);
$qb2->setParameter('label', mb_strcut($recipient->getLabel(), 0, 255), IQueryBuilder::PARAM_STR);
$qb2->setParameter('email', mb_strcut($recipient->getEmail(), 0, 255), IQueryBuilder::PARAM_STR);
$qb2->setParameter('label', mb_strcut($recipient->getLabel() ?? $recipientEmail, 0, 255), IQueryBuilder::PARAM_STR);
$qb2->setParameter('email', mb_strcut($recipientEmail, 0, 255), IQueryBuilder::PARAM_STR);

$qb2->executeStatement();
}
Expand Down
1 change: 1 addition & 0 deletions lib/Service/Classification/FeatureExtraction/ImportantMessagesExtractor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ public function extract(Message $message): array {
// Prevent div by 0
return [0];
}
/** @psalm-suppress PossiblyNullArrayOffset */
return [($this->flaggedMessages[$email] ?? 0) / $total];
}
}
1 change: 1 addition & 0 deletions lib/Service/Classification/FeatureExtraction/ReadMessagesExtractor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ public function extract(Message $message): array {
return [0];
}

/** @psalm-suppress PossiblyNullArrayOffset */
return [($this->readMessages[$email] ?? 0) / $total];
}
}
1 change: 1 addition & 0 deletions lib/Service/Classification/FeatureExtraction/RepliedMessagesExtractor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ public function extract(Message $message): array {
return [0];
}

/** @psalm-suppress PossiblyNullArrayOffset */
return [($this->repliedMessages[$email] ?? 0) / $total];
}
}
Loading