Skip to content

fix(ui): report failed one-click unsubscribe requests - #14003

Open
GVodyanov wants to merge 1 commit into
mainfrom
fix/unsubscribe-one-click-errors
Open

GVodyanov wants to merge 1 commit into
mainfrom
fix/unsubscribe-one-click-errors

Conversation

@GVodyanov

Copy link
Copy Markdown
Contributor

ListService.unsubscribe didn't await axios.post, so a failed one-click unsubscribe (RFC 8058) never reached the caller's catch and the user always saw "Unsubscribe request sent".

The request is now awaited, so server errors show "Could not unsubscribe from mailing list".

How to test

  1. Open a newsletter with a valid DKIM signature and a one-click List-Unsubscribe header pointing to an unreachable host
  2. Unsubscribe → Unsubscribe
  3. The error toast appears (before: false success)

Found during the QA round in #13797. AI-assisted (Claude Code); reviewed and tested by me.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

The unsubscribe request was not awaited, so the caller always showed
"Unsubscribe request sent", even when the server could not reach the
list's unsubscribe URL, and the rejection went unhandled.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
@GVodyanov GVodyanov self-assigned this Nov 1, 2026
@nextcloud-command nextcloud-command added the AI assisted This PR contains AI-assisted commits label Nov 1, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review AI assisted This PR contains AI-assisted commits

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants