Skip to content

fix(file-provider): Fix handling of item renamed into excluded pattern - #10780

Open
claucambra wants to merge 2 commits into
masterfrom
work/exclude-fp-fix
Open

fix(file-provider): Fix handling of item renamed into excluded pattern#10780
claucambra wants to merge 2 commits into
masterfrom
work/exclude-fp-fix

Conversation

@claucambra

@claucambra claucambra commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Resolves

#10645

Summary

Exclusion during modify should check for path the item was renamed into, not just the original
Match the classic sync engine behaviour of deleting remote item when item is renamed into ignore pattern

Checklist

AI (if applicable)

@claucambra
fix(file-provider): Fix handling of item renamed into excluded pattern
b0dfb37 
Exclusion during modify should check for path the item was renamed into, not just the original
Match the classic sync engine behaviour of deleting remote item when item is renamed into ignore pattern

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra claucambra added this to the 34.0.4 milestone Sep 10, 2026
@claucambra claucambra self-assigned this Sep 10, 2026
@claucambra claucambra added the os: 🍎 macOS Apple macOS, formerly also known as OS X label Sep 10, 2026
@claucambra claucambra added the feature: 📁 file provider macOS File Provider Extension, more general also known as virtual file system. label Sep 10, 2026
@claucambra
fix(file-provider): test expected ignore pattern/rename into exclusio…
5a42749 
…n behaviour

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-10780.zip

Digest: sha256:5420eeb890ae444b03e8e1097e9872aafd8fdee494d578455931038fea73f3dd

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Artifact containing the Flatpak bundle: com.nextcloud.desktopclient.nextcloud.flatpak.zip

Digest: sha256:b762e3c4fc5351a2b4a1efe00a58f6fbdc83085e2c2f099952137f31a34fc30d

To test this change/fix you can download the above artifact file, unzip it, and install the bundle with:
flatpak install --user com.nextcloud.desktopclient.nextcloud.flatpak

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud

sonarqubecloud Bot commented Sep 10, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@claucambra claucambra linked an issue Sep 10, 2026 that may be closed by this pull request
[Bug]: Renaming a synced file into an excluded name strands its replacement forever (silent data loss, UI shows synced) #10645
Open
@claucambra claucambra modified the milestones: 34.0.4, 34.0.5 Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rello Rello Rello approved these changes
@camilasan camilasan Awaiting requested review from camilasan camilasan is a code owner
@i2h3 i2h3 Awaiting requested review from i2h3 i2h3 is a code owner
@mgallien mgallien Awaiting requested review from mgallien mgallien is a code owner
@nilsding nilsding Awaiting requested review from nilsding nilsding is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@claucambra claucambra

Labels

feature: 📁 file provider macOS File Provider Extension, more general also known as virtual file system. os: 🍎 macOS Apple macOS, formerly also known as OS X

Projects

None yet

Milestone

34.0.5

Development

Successfully merging this pull request may close these issues.

[Bug]: Renaming a synced file into an excluded name strands its replacement forever (silent data loss, UI shows synced)

2 participants

@claucambra @Rello