Repository navigation
Conversation
Signed-off-by: pducharme <pducharme@gestioo.co>
Signed-off-by: pducharme <pducharme@gestioo.co>
Signed-off-by: pducharme <pducharme@gestioo.co>
pducharme
force-pushed
the
fix/nextcloud-36-compatibility
branch
from
September 17, 2026 12:49
daa2bf6 to
914293e
Compare
Signed-off-by: pducharme <pducharme@gestioo.co>
Signed-off-by: pducharme <pducharme@gestioo.co>
pducharme
marked this pull request as ready for review
September 17, 2026 13:27
Member
|
Thank you @pducharme for taking this on. I have a few opinionated alterations to this, so I've whipped up #2542 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bookmarks declares compatibility only through Nextcloud 34, preventing normal activation on Nextcloud 35 and the current 36 development branch. The newer public schema interface also no longer exposes
changeColumn, which Psalm reports in an older migration.This change extends the supported range to 36 and replaces that call with
modifyColumn, preserving the column type and unsigned setting. Application IDs, REST endpoints, authentication and stored data formats are unchanged.The existing manifest-driven PHPUnit/Psalm matrices cover the added versions. SQLite activation now runs without
--force; upgrade tests add v16.2.6 on 35/master with SQLite, MariaDB and PostgreSQL and compare exported bookmarks before/after. MariaDB services meet the new server minimum. Floccus tests use Nextcloud source checkouts for stable32, stable35 and master so development-server coverage does not depend on a released Docker tag.Validation
The fork validation runs use the same application code with standard GitHub runners in place of the organization's
ubuntu-latest-lowrunners:Upstream workflows currently require maintainer approval. Dependency Review cannot run in the fork because its dependency graph is disabled; no application dependency changes are included here. Nextcloud master currently identifies itself as
36.0.0 dev, so results do not attest a future final release. No production instance or personal browser data has been accessed.Prepared with assistance from OpenAI Codex.