Common network stack

[tobiasKaminsky]

Goal:

• api 'com.squareup.okhttp3:okhttp:5.5.0'
• api 'com.github.bitfireAT:dav4jvm:2.2.1'
• api 'com.squareup.retrofit2:retrofit:3.0.0'
  • Is only served via library.
  • Files, Talk, Notes (indirectly via SSO) use this.
• Retrofit api is extracted to library, so that also other 3rd party apps can use it (showcase with new api interface)

To discuss:

• general approach
• structure
• …

PRs:
Files: nextcloud/android#17760
Talk: nextcloud/talk-android#6802
Notes: nextcloud/notes-android#3372

🤖 AI (if applicable)

• The content of this PR was partly or fully generated using AI (N/A)

[alperozturk96]

I think before continuing we should agree on things I mentioned.

Package order:

/users
/users/model/UserInfoResponse
/users/repository/UserRemoteRepository
/users/UserApi

---

Also we should add this to the skills.

[alperozturk96]

Since we are starting something new.

Prefixes like get, set should be used for internal data class, POJO object change like setName, getName or getting data from internal db.

and fetch should be used for remote operation thus we can have clear distinction between them.

[alperozturk96]

Why we are exposing non-suspended version of the same function. Library should enforce the consumer to use suspending version of it. Thus we don't create more technical debts, ANRs.

Also library should never expose the suspend function calls without correct threading. This needs to be forced as well.

e.g.

interface UserApi -> this will be internal in the library

class UserRemoteRepository( -> this will be public
    private val api: UserApi
) {
    suspend fun fetchUser(): OcsKotlinResponse<UserInfoResponse> =
        withContext(Dispatchers.IO) {
            api.fetchUser("json")
        }
}

[github-actions]

SpotBugs

Category	Base	New
Bad practice	31	31
Correctness	28	28
Dodgy code	13	13
Internationalization	6	6
Malicious code vulnerability	26	26
Multithreaded correctness	7	7
Performance	3	3
Security	3	3
Total	117	117

[github-actions]

SpotBugs

Category	Base	New
Bad practice	31	31
Correctness	28	28
Dodgy code	13	13
Internationalization	6	6
Malicious code vulnerability	26	26
Multithreaded correctness	7	7
Performance	3	3
Security	3	3
Total	117	117