Skip to content

fix(ocp-server-rector): Fix phpstan issue - #102

Closed
nickvergessen wants to merge 1 commit into
mainfrom
bugfix/noid/fix-phpstan
Closed

fix(ocp-server-rector): Fix phpstan issue#102
nickvergessen wants to merge 1 commit into
mainfrom
bugfix/noid/fix-phpstan

Conversation

@nickvergessen

@nickvergessen nickvergessen commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Seems this broke inbetween, maybe by a new PHPStan version or something:

Note: Using configuration file …/phpstan.neon.dist.
 44/44 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ------------------------------------------------------------------------------------------------------------------------------ 
  Line   src/Rector/LegacyGetterToOcpServerGetRector.php                                                                               
 ------ ------------------------------------------------------------------------------------------------------------------------------ 
  117    Property Nextcloud\Rector\Rector\LegacyGetterToOcpServerGetRector::$legacyGetterToOcpServerGet (array<Nextcloud\Rector\Value  
         Object\LegacyGetterToOcpServerGet>) does not accept array<mixed>.                                                             
         🪪  assign.propertyType                                                                                                       
 ------ ------------------------------------------------------------------------------------------------------------------------------ 


                                                                                                                        
 [ERROR] Found 1 error                                                                                                  
                               
  • Assisted-by: ClaudeCode:claude-opus-5

PR checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen self-assigned this Sep 1, 2026
@nickvergessen nickvergessen added bug Something isn't working AI assisted This PR contains AI-assisted commits labels Sep 1, 2026
@nickvergessen

Copy link
Copy Markdown
Contributor Author

Cool, I didn't see that one locally… what's going on here…

@nickvergessen

Copy link
Copy Markdown
Contributor Author

Okay we don't have a composer.lock file… But I don't have time to dive into this further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI assisted This PR contains AI-assisted commits bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant