[proxy] remove cluster tag from proxy metrics

[pascal-fischer]

Describe your changes

Issue ticket number and link

Stack

Checklist

• Is it a bug fix
• Is a typo/documentation fix
• Is a feature enhancement
• It is a refactor
• Created tests that fail without the change (if possible)
• This change does not modify the public API, gRPC protocols, functionality behavior, CLI / service flags, or introduce a new feature — OR I have discussed it with the NetBird team beforehand (link the issue / Slack thread in the description). See CONTRIBUTING.md.

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

• I added/updated documentation for this change
• Documentation is not needed for this change (explain why)

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

https://github.com/netbirdio/docs/pull/__

Summary by CodeRabbit

• Bug Fixes
  • Improved proxy and service metrics reliability by removing cluster-specific labels from metric updates.
  • Standardized connection, service update, and heartbeat measurements for more consistent monitoring.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a2983a8f-043e-445f-9f1d-b1160ef77d95

📥 Commits

Reviewing files that changed from the base of the PR and between c1f0006 and b27d7cf.

📒 Files selected for processing (2)

• management/internals/modules/reverseproxy/proxy/manager/controller.go
• management/internals/modules/reverseproxy/proxy/manager/metrics.go

---

📝 Walkthrough

Walkthrough

Proxy manager metrics now use attribute-free, parameterless updates. Controller call sites were updated for service updates and proxy registration lifecycle events.

Changes

Proxy manager metric updates

Layer / File(s)	Summary
Simplify metric updates management/internals/modules/reverseproxy/proxy/manager/metrics.go	Removes cluster metric attributes and changes proxy, service-update, and heartbeat instrument updates to use fixed deltas.
Update controller metric calls management/internals/modules/reverseproxy/proxy/manager/controller.go	Updates service update, proxy registration, and proxy unregistration paths to call parameterless metric methods.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The template is present, but the change summary, issue link, stack, and docs explanation are not filled in.	Add a short change summary, the issue ticket/link, stack details, and a reason for why documentation is not needed.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: removing the cluster tag from proxy metrics.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch remove-cluster-tag-from-metrics

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Release artifacts

Built for PR head b27d7cf in workflow run #17295.

Artifact	Link
All release artifacts	Download
Linux packages	Download
Windows packages	Download
macOS packages	Download
UI artifacts	Download
UI macOS artifacts	Download

GHCR images (amd64)

• ghcr.io/netbirdio/management:pr-6985
• ghcr.io/netbirdio/netbird-server:pr-6985
• ghcr.io/netbirdio/netbird:pr-6985
• ghcr.io/netbirdio/relay:pr-6985
• ghcr.io/netbirdio/reverse-proxy:pr-6985
• ghcr.io/netbirdio/signal:pr-6985
• ghcr.io/netbirdio/upload:pr-6985

This comment is updated by the Release workflow. Artifact links expire according to the workflow retention policy.