re-implement some ArchUnit code to support scanning package-info - #58
Merged
Conversation
wakingrufus
force-pushed
the
package-info-fix
branch
from
February 19, 2026 17:35
d3ac34d to
2d3e0fb
Compare
wakingrufus
marked this pull request as ready for review
February 19, 2026 17:42
… class dependency when scanning since TNG/ArchUnit#1565 has not been merged in a timely manner, we need a custom implementation on our end to fix this issue until it is finally merged.
wakingrufus
force-pushed
the
package-info-fix
branch
from
February 19, 2026 17:44
2d3e0fb to
58060a2
Compare
emilyyuan03
reviewed
Feb 19, 2026
| lateinit var projectDir: File | ||
|
|
||
| @Test | ||
| fun `package rules work for external packages`() { |
Contributor
There was a problem hiding this comment.
Exported instead of External?
Member
Author
There was a problem hiding this comment.
external means from another jar in this case. the issue is that package level annotations on code from dependencies (code that is not being evaluated) are not currently visible
emilyyuan03
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re-implement some ArchUnit code to support treating package-info as a class dependency when scanning
since TNG/ArchUnit#1565 has not been merged in a timely manner, we need a custom implementation on our end to fix this issue until it is finally merged.