Skip to content

Lad clock - #8452

Open
akhenry wants to merge 17 commits into
masterfrom
lad-clock
Open

akhenry wants to merge 17 commits into
masterfrom
lad-clock

Conversation

@akhenry

@akhenry akhenry commented Sep 25, 2026

Copy link
Copy Markdown
Member

Closes

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

Comment thread .github/scripts/contribution-gate/markdownSections.js Fixed
Comment thread .github/scripts/contribution-gate/prCompliance.js Fixed
@codecov

codecov Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 79.31034% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.00%. Comparing base (e09bfaf) to head (d658b45).

Files with missing lines Patch % Lines
src/utils/clock/clockReadyRequestInterceptor.js 10.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8452      +/-   ##
==========================================
+ Coverage   56.90%   57.00%   +0.10%     
==========================================
  Files         731      733       +2     
  Lines       30057    30116      +59     
  Branches     2857     2857              
==========================================
+ Hits        17103    17167      +64     
+ Misses      12622    12617       -5     
  Partials      332      332              
Flag Coverage Δ
e2e-ci 65.12% <17.24%> (-0.18%) ⬇️
e2e-full 39.19% <16.09%> (-0.02%) ⬇️
unit 45.86% <79.31%> (+0.11%) ⬆️
Files with missing lines Coverage Δ
src/api/telemetry/TelemetryAPI.js 91.09% <100.00%> (+1.02%) ⬆️
src/plugins/plugins.js 100.00% <100.00%> (ø)
src/plugins/remoteClock/RemoteClock.js 97.50% <100.00%> (+16.25%) ⬆️
src/plugins/telemetryClock/TelemetryClock.js 100.00% <100.00%> (ø)
src/plugins/telemetryClock/plugin.js 100.00% <100.00%> (ø)
src/utils/clock/clockReadyRequestInterceptor.js 10.00% <10.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e09bfaf...d658b45. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@akhenry akhenry added this to the Next milestone Sep 25, 2026
@akhenry
akhenry marked this pull request as ready for review September 26, 2026 00:26
@akhenry
akhenry marked this pull request as draft September 26, 2026 01:23
@akhenry
akhenry marked this pull request as ready for review September 29, 2026 23:33
@akhenry

akhenry commented Oct 1, 2026

Copy link
Copy Markdown
Member Author

@claude review

1 similar comment
@akhenry

akhenry commented Oct 1, 2026

Copy link
Copy Markdown
Member Author

@claude review

The contribution gate, the CI changes and the contribution policy moved
to #8453, so this branch is about the LAD clock alone. Every
workflow and process file goes back to master's version.
Brings in AGENTS.md (#8379).
AGENTS.md (#8379) on master now provides this guidance, in a newer form,
so these copies are redundant. The .gitignore entry for .claude/ comes
back with them gone.
Commits made with Claude Code end with "Made with Claude" rather than a
Co-Authored-By trailer. .claude/settings.json is the shared project
settings file, so it is committed; everything else under .claude/ stays
local.
Empty strings rather than false, because Claude Code versions before
2.1.281 reject false and would skip the whole project settings file.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants