Skip to content

Windows tests - #79

Open
robertmin1 wants to merge 1 commit into
namecoin:masterfrom
robertmin1:windows-tests
Open

Windows tests#79
robertmin1 wants to merge 1 commit into
namecoin:masterfrom
robertmin1:windows-tests

Add AIA functional tests and fix server lint warnings (windows)

409d91c
Select commit
Loading
Failed to load commit list.
Cirrus CI / Go Lint windows completed Apr 10, 2026 in 39s

Task Summary

Instruction lint failed in 00:28

Details

⚠️ Not enough compute credits to prioritize tasks!
ℹ️ Scheduling was delayed due to a concurrency limit on community tasks

✅ 00:00 clone
✅ 00:03 install
✅ 00:01 path
✅ 00:01 kingpin
✅ 00:02 fetch
❌ 00:28 lint

cd $(go env GOPATH)/src/github.com/$CIRRUS_REPO_FULL_NAME/
golangci-lint run $GOLANGCI_ARGS -v --timeout 5m --output.json.path $CIRRUS_WORKING_DIR/lint-report.json
level=info msg="golangci-lint has version 2.11.4 built with go1.26.1 from 8f3b0c7e on 2026-03-22T17:35:14Z"
level=info msg="[config_reader] Config search paths: [./ /go/src/github.com/namecoin/encaya /go/src/github.com/namecoin /go/src/github.com /go/src /go / /root]"
level=info msg="[config_reader] Used config file .golangci.yml"
level=info msg="[config_reader] Module name \"github.com/namecoin/encaya\""
level=info msg="[goenv] Read go env for 2.93447ms: map[string]string{\"GOCACHE\":\"/root/.cache/go-build\", \"GOROOT\":\"/usr/local/go\"}"
level=info msg="[lintersdb] Active 17 linters: [cyclop err113 errcheck forcetypeassert funlen gocognit goconst gocritic gosec govet ineffassign mnd modernize nlreturn staticcheck unused wsl_v5]"
level=info msg="[loader] Go packages loading at mode 8767 (deps|files|name|types_sizes|compiled_files|exports_file|imports) took 21.679692824s"
level=info msg="[runner/filename_unadjuster] Pre-built 0 adjustments in 1.20653ms"
level=info msg="[linters_context/goanalysis] analyzers took 8.009913951s with top 10 stages: buildir: 6.472103726s, printf: 356.161599ms, inspect: 183.405867ms, gosec: 162.624294ms, fact_purity: 134.270444ms, ctrlflow: 112.421754ms, nilness: 112.016362ms, newexpr: 103.445464ms, SA5012: 93.637563ms, fact_deprecated: 79.774496ms"
level=info msg="[runner/max_same_issues] 13/16 issues with text \"return with no blank line before\" were hidden, use --max-same-issues"
level=info msg="[runner/max_same_issues] 3/6 issues with text \"G120: Parsing form data without limiting request body size can allow memory exhaustion (use http.MaxBytesReader)\" were hidden, use --max-same-issues"
level=info msg="[runner/max_same_issues] 2/5 issues with text \"continue with no blank line before\" were hidden, use --max-same-issues"
level=info msg="[runner/max_same_issues] 1/4 issues with text \"Magic number: 0600, in <argument> detected\" were hidden, use --max-same-issues"
level=info msg="[runner] Issues before processing: 80, after processing: 48"
level=info msg="[runner] Processors filtering stat (in/out): exclusion_rules: 80/80, diff: 76/76, uniq_by_line: 76/67, path_relativity: 80/80, exclusion_paths: 80/80, max_per_file_from_linter: 67/67, max_same_issues: 67/48, max_from_linter: 48/48, path_prettifier: 48/48, path_absoluter: 80/80, generated_file_filter: 80/80, source_code: 48/48, severity-rules: 48/48, sort_results: 48/48, cgo: 80/80, filename_unadjuster: 80/80, invalid_issue: 80/80, nolint_filter: 80/76, fixer: 76/76, path_shortener: 48/48"
level=info msg="[runner] processing took 1.866714ms with stages: nolint_filter: 1.54307ms, source_code: 96.08µs, generated_file_filter: 92.771µs, max_same_issues: 52.162µs, path_relativity: 40.88µs, uniq_by_line: 13.102µs, sort_results: 8.18µs, max_from_linter: 5.24µs, path_shortener: 4.651µs, invalid_issue: 2.17µs, cgo: 2.009µs, max_per_file_from_linter: 1.609µs, path_absoluter: 1.24µs, path_prettifier: 829ns, filename_unadjuster: 819ns, fixer: 591ns, exclusion_rules: 500ns, exclusion_paths: 380ns, diff: 331ns, severity-rules: 100ns"
level=info msg="[runner] linters took 6.419199156s with stages: goanalysis_metalinter: 6.417255116s"
48 issues:
* cyclop: 3
* err113: 4
* forcetypeassert: 1
* gocognit: 1
* goconst: 1
* gocritic: 3
* gosec: 4
* mnd: 13
* modernize: 4
* nlreturn: 6
* wsl_v5: 8
level=info msg="File cache stats: 3 entries of total size 29.7KiB"
level=info msg="Memory: 283 samples, avg is 104.2MB, max is 408.7MB"
level=info msg="Execution took 28.10367894s"
������������

Annotations

Check failure on line 579 in server/server.go

See this annotation in the file changed.

@cirrus-ci cirrus-ci / Go Lint windows

server/server.go#L579

calculated cyclomatic complexity for function lookupCert is 14, max is 10 (cyclop)

Check failure on line 846 in server/server.go

See this annotation in the file changed.

@cirrus-ci cirrus-ci / Go Lint windows

server/server.go#L846

calculated cyclomatic complexity for function GenerateCerts is 13, max is 10 (cyclop)

Check failure on line 35 in verifystapled/verify.go

See this annotation in the file changed.

@cirrus-ci cirrus-ci / Go Lint windows

verifystapled/verify.go#L35

calculated cyclomatic complexity for function Verify is 19, max is 10 (cyclop)

Check failure on line 459 in server/server.go

See this annotation in the file changed.

@cirrus-ci cirrus-ci / Go Lint windows

server/server.go#L459

do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf(\"qlib error: nil response\")" (err113)

Check failure on line 465 in server/server.go

See this annotation in the file changed.

@cirrus-ci cirrus-ci / Go Lint windows

server/server.go#L465

do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf(\"qlib error: return code not Success or NXDOMAIN\")" (err113)

Check failure on line 38 in verifystapled/verify.go

See this annotation in the file changed.

@cirrus-ci cirrus-ci / Go Lint windows

verifystapled/verify.go#L38

do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf(\"empty message header\")" (err113)

Check failure on line 43 in verifystapled/verify.go

See this annotation in the file changed.

@cirrus-ci cirrus-ci / Go Lint windows

verifystapled/verify.go#L43

do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf(\"empty pubtype\")" (err113)

Check failure on line 755 in server/server.go

See this annotation in the file changed.

@cirrus-ci cirrus-ci / Go Lint windows

server/server.go#L755

right hand must be only type assertion (forcetypeassert)

Check failure on line 431 in server/server.go

See this annotation in the file changed.

@cirrus-ci cirrus-ci / Go Lint windows

server/server.go#L431

cognitive complexity 52 of func `(*Server).lookupDNS` is high (> 30) (gocognit)

Check failure on line 582 in server/server.go

See this annotation in the file changed.

@cirrus-ci cirrus-ci / Go Lint windows

server/server.go#L582

string `Namecoin Root CA` has 3 occurrences, make it a constant (goconst)

Check failure on line 514 in server/server.go

See this annotation in the file changed.

@cirrus-ci cirrus-ci / Go Lint windows

server/server.go#L514

ifElseChain: rewrite if-else to switch statement (gocritic)

Check failure on line 531 in server/server.go

See this annotation in the file changed.

@cirrus-ci cirrus-ci / Go Lint windows

server/server.go#L531

commentFormatting: put a space between `//` and comment text (gocritic)

Check failure on line 59 in verifystapled/verify.go

See this annotation in the file changed.

@cirrus-ci cirrus-ci / Go Lint windows

verifystapled/verify.go#L59

ifElseChain: rewrite if-else to switch statement (gocritic)

Check failure on line 664 in server/server.go

See this annotation in the file changed.

@cirrus-ci cirrus-ci / Go Lint windows

server/server.go#L664

G120: Parsing form data without limiting request body size can allow memory exhaustion (use http.MaxBytesReader) (gosec)

Check failure on line 712 in server/server.go

See this annotation in the file changed.

@cirrus-ci cirrus-ci / Go Lint windows

server/server.go#L712

G120: Parsing form data without limiting request body size can allow memory exhaustion (use http.MaxBytesReader) (gosec)

Check failure on line 737 in server/server.go

See this annotation in the file changed.

@cirrus-ci cirrus-ci / Go Lint windows

server/server.go#L737

G705: XSS via taint analysis (gosec)

Check failure on line 838 in server/server.go

See this annotation in the file changed.

@cirrus-ci cirrus-ci / Go Lint windows

server/server.go#L838

G120: Parsing form data without limiting request body size can allow memory exhaustion (use http.MaxBytesReader) (gosec)

Check failure on line 231 in server/server.go

See this annotation in the file changed.

@cirrus-ci cirrus-ci / Go Lint windows

server/server.go#L231

Magic number: 5, in <assign> detected (mnd)

Check failure on line 232 in server/server.go

See this annotation in the file changed.

@cirrus-ci cirrus-ci / Go Lint windows

server/server.go#L232

Magic number: 10, in <assign> detected (mnd)

Check failure on line 241 in server/server.go

See this annotation in the file changed.

@cirrus-ci cirrus-ci / Go Lint windows

server/server.go#L241

Magic number: 5, in <assign> detected (mnd)

Check failure on line 242 in server/server.go

See this annotation in the file changed.

@cirrus-ci cirrus-ci / Go Lint windows

server/server.go#L242

Magic number: 10, in <assign> detected (mnd)

Check failure on line 423 in server/server.go

See this annotation in the file changed.

@cirrus-ci cirrus-ci / Go Lint windows

server/server.go#L423

Magic number: 600, in <assign> detected (mnd)

Check failure on line 424 in server/server.go

See this annotation in the file changed.

@cirrus-ci cirrus-ci / Go Lint windows

server/server.go#L424

Magic number: 2, in <assign> detected (mnd)

Check failure on line 551 in server/server.go

See this annotation in the file changed.

@cirrus-ci cirrus-ci / Go Lint windows

server/server.go#L551

Magic number: 2, in <condition> detected (mnd)

Check failure on line 731 in server/server.go

See this annotation in the file changed.

@cirrus-ci cirrus-ci / Go Lint windows

server/server.go#L731

Magic number: 2, in <operation> detected (mnd)