Repository navigation
chore: update Namadillo to work with new 4.0.3 indexer client - #2296
Merged
Merged
Conversation
Author
|
This PR is to prepare for Gian's indexer changes here |
added 13 commits
September 6, 2025 11:12
neocybereth
changed the title
neocybereth
changed the title
mateuszjasiuk
force-pushed
the
fix/governance-pr
branch
from
September 12, 2025 09:14
7cafa59 to
dd38f42
Compare
mateuszjasiuk
force-pushed
the
fix/governance-pr
branch
from
September 12, 2025 09:18
dd38f42 to
cff6807
Compare
mateuszjasiuk
approved these changes
Sep 12, 2025
mateuszjasiuk
changed the title
jurevans
reviewed
Sep 12, 2025
| ?.filter(({ tokenAddress: ta }) => ta === tokenAddress.data) | ||
| .map(({ tokenAddress, minDenomAmount }) => ({ | ||
| token: tokenAddress, | ||
| ?.filter(({ token: ta }) => ta.address === tokenAddress.data) |
Collaborator
There was a problem hiding this comment.
very nitpick, but it's not needed to alias this param. Could either be like { token } or { token: { address }} - not a big deal though :D
jurevans
approved these changes
Sep 12, 2025
jurevans
left a comment
jurevans
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Only left one minor comment, nothing important though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to test?
❗ We need to remove @namada/types in the next PR and release new version of the sdkjs