Skip to content

fix: Update keplr connect check and update to use latest SDK #2295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neocybereth merged 3 commits into from
Sep 8, 2025
Merged

fix: Update keplr connect check and update to use latest SDK #2295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63500b0
fix: update connected wallet check
Sep 5, 2025
6f9f5ef
fix: add yarn
Sep 5, 2025
bc26b16
fix: remove loop potential
Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/namadillo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"@keplr-wallet/types": "^0.12.136",
"@namada/chain-registry": "^1.3.0",
"@namada/indexer-client": "3.3.2",
"@namada/sdk-multicore": "^0.20.7",
"@namada/sdk-multicore": "^0.20.8",
"@tailwindcss/container-queries": "^0.1.1",
"@tanstack/query-core": "^5.40.0",
"@tanstack/react-query": "^5.40.0",
Expand Down Expand Up @@ -79,7 +79,7 @@
},
"devDependencies": {
"@eslint/js": "^9.9.1",
"@namada/sdk-node": "^0.20.7",
"@namada/sdk-node": "^0.20.8",
"@namada/vite-esbuild-plugin": "^1.0.1",
"@playwright/test": "^1.24.1",
"@svgr/webpack": "^6.5.1",
Expand Down
2 changes: 1 addition & 1 deletion apps/namadillo/src/App/Common/TransactionReceipt.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Chain } from "@chain-registry/types";
import { CopyToClipboardControl, Stack } from "@namada/components";
import { PseudoExtendedKey } from "@namada/sdk/web";
import { PseudoExtendedKey } from "@namada/sdk-multicore";
import { shortenAddress } from "@namada/utils";
import {
isNamadaAddress,
Expand Down
10 changes: 10 additions & 0 deletions apps/namadillo/src/App/Layout/KeplrAccount.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,22 @@
import { connectedWalletsAtom } from "atoms/integrations";
import { useWalletManager } from "hooks/useWalletManager";
import { wallets } from "integrations";
import { KeplrWalletManager } from "integrations/Keplr";
import { useAtom } from "jotai";
import { useEffect } from "react";
import { AccountIconButton } from "./AccountIconButton";
import { DisconnectAccountIcon } from "./DisconnectAccountIcon";

export const KeplrAccount = (): JSX.Element => {
const [connectedWallets, setConnectedWallets] = useAtom(connectedWalletsAtom);
const keplrWallet = new KeplrWalletManager();
const { walletAddress: connectedKeplrAddress } =

@neocybereth neocybereth Sep 5, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes this scenario where you:

  1. Connect to Keplr
  2. Close the browser tab
  3. Reopen a fresh tab
  4. Keplr signin popup comes in out of nowhere b/c part of the frontend thinks you're connected to Keplr. You'll notice that the top nav shows Keplr as connected but the "Connect Wallet" button still exists.
Screen.Recording.2025-09-05.at.9.58.11.AM.mov

useWalletManager(keplrWallet);

useEffect(() => {
if (!connectedKeplrAddress)
setConnectedWallets((obj) => ({ ...obj, [keplrWallet.key]: false }));
}, [connectedKeplrAddress]);

if (!connectedWallets.keplr) {
return <></>;
Expand Down
29 changes: 23 additions & 6 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3765,8 +3765,8 @@ __metadata:
"@keplr-wallet/types": "npm:^0.12.136"
"@namada/chain-registry": "npm:^1.3.0"
"@namada/indexer-client": "npm:3.3.2"
"@namada/sdk-multicore": "npm:^0.20.7"
"@namada/sdk-node": "npm:^0.20.7"
"@namada/sdk-multicore": "npm:^0.20.8"
"@namada/sdk-node": "npm:^0.20.8"
"@namada/vite-esbuild-plugin": "npm:^1.0.1"
"@playwright/test": "npm:^1.24.1"
"@svgr/webpack": "npm:^6.5.1"
Expand Down Expand Up @@ -3852,9 +3852,9 @@ __metadata:
languageName: unknown
linkType: soft

"@namada/sdk-multicore@npm:^0.20.7":
version: 0.20.7
resolution: "@namada/sdk-multicore@npm:0.20.7"
"@namada/sdk-multicore@npm:^0.20.8":
version: 0.20.8
resolution: "@namada/sdk-multicore@npm:0.20.8"
dependencies:
"@cosmjs/encoding": "npm:^0.29.0"
"@dao-xyz/borsh": "npm:^5.1.5"
Expand All @@ -3865,7 +3865,7 @@ __metadata:
buffer: "npm:^6.0.3"
semver: "npm:^7.7.2"
slip44: "npm:^3.0.18"
checksum: 10c0/954de17370d879af0781454f3f13239c3e2557592f353051fbcd7236d18ed0d084bd3d23c67995701cc5bb07abd15b39568d366c8d632a72efe8c70dd60956f9
checksum: 10c0/ad36e368790e3e18275672a036c7fecf6e3554098b856186daa7656cafb015fd76a7b10dcd8f78ca53303592f1c67908a159cd4b18d5ad5bd3737bb681c88438
languageName: node
linkType: hard

Expand All @@ -3886,6 +3886,23 @@ __metadata:
languageName: node
linkType: hard

"@namada/sdk-node@npm:^0.20.8":
version: 0.20.8
resolution: "@namada/sdk-node@npm:0.20.8"
dependencies:
"@cosmjs/encoding": "npm:^0.29.0"
"@dao-xyz/borsh": "npm:^5.1.5"
"@ledgerhq/hw-transport": "npm:^6.31.4"
"@ledgerhq/hw-transport-webusb": "npm:^6.29.4"
"@zondax/ledger-namada": "npm:^2.0.0"
bignumber.js: "npm:^9.1.1"
buffer: "npm:^6.0.3"
semver: "npm:^7.7.2"
slip44: "npm:^3.0.18"
checksum: 10c0/8632dd2a5995f310d0aa7ad5c11ef8b50a71ca83da33560ff688231c35312e4ed59234aa32b5bc336767917930e20a3ae30538a6bb73eb9825f2196dd5e8c427
languageName: node
linkType: hard

"@namada/sdk@npm:^0.20.7":
version: 0.20.7
resolution: "@namada/sdk@npm:0.20.7"
Expand Down