Skip to content

B04: Shell settings and shared contracts - #6

Closed
myk1yt wants to merge 7 commits into
mainfrom
pr/b04-shell-contracts
Closed

myk1yt wants to merge 7 commits into
mainfrom
pr/b04-shell-contracts

Conversation

@myk1yt

@myk1yt myk1yt commented Jul 28, 2026

Copy link
Copy Markdown
Owner

WHY

Land backward-compatible shell settings and cached-state UI binding before runtime consumers. Settings inputs must bind to the local cachedState, not directly to live extension state.

Scope

  • Terminal settings types (global-settings.ts, terminal.ts)
  • Shell settings IPC types in vscode-extension-host.ts (shell-only hunks)
  • TerminalSettings.tsx component with cached-state binding
  • SettingsView.tsx integration (shell-only hunk)
  • English locale strings for shell settings (settings.json)
  • Focused tests for types and component

Dependencies

None (Wave 1, from upstream/main at d27153a25).

Non-goals

  • Shell resolution/runtime primitives (B05)
  • Terminal lifecycle/scheduling (B06)
  • Command tool/IPC integration (B07)
  • No task-organization or stats types/UI

Verification

  • cd packages/types; npx vitest run src/__tests__/terminal-shell-settings.spec.ts — 28/28 passed
  • cd webview-ui; npx vitest run src/components/settings/__tests__/TerminalSettings.shell.spec.tsx — 7/7 passed
  • Type checks clean (packages/types + webview-ui)

Shared-file note

  • vscode-extension-host.ts will be extended by B07 (command/task types), B09 (task-org types), B16 (stats types)
  • SettingsView.tsx will be extended by B10 (task-org UI), B16 (stats UI)
  • settings.json will be extended by B10, B16 for other concern strings

Exclusion attestation

No reports, helpers, stale reversions, unrelated changesets, or operational noise. McpView simplification correctly excluded.

@myk1yt myk1yt closed this Jul 29, 2026
@myk1yt
myk1yt deleted the pr/b04-shell-contracts branch August 7, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant