Repository navigation
Conversation
added 7 commits
July 28, 2026 09:01
…add ignoreBinaries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY
Land backward-compatible shell settings and cached-state UI binding before runtime consumers. Settings inputs must bind to the local cachedState, not directly to live extension state.
Scope
global-settings.ts,terminal.ts)vscode-extension-host.ts(shell-only hunks)TerminalSettings.tsxcomponent with cached-state bindingSettingsView.tsxintegration (shell-only hunk)settings.json)Dependencies
None (Wave 1, from
upstream/mainatd27153a25).Non-goals
Verification
cd packages/types; npx vitest run src/__tests__/terminal-shell-settings.spec.ts— 28/28 passedcd webview-ui; npx vitest run src/components/settings/__tests__/TerminalSettings.shell.spec.tsx— 7/7 passedShared-file note
vscode-extension-host.tswill be extended by B07 (command/task types), B09 (task-org types), B16 (stats types)SettingsView.tsxwill be extended by B10 (task-org UI), B16 (stats UI)settings.jsonwill be extended by B10, B16 for other concern stringsExclusion attestation
No reports, helpers, stale reversions, unrelated changesets, or operational noise. McpView simplification correctly excluded.