Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #978.
Summary
Fix all nine findings from the review, without incorporating the separate fixes already proposed in open PRs:
check-iocsdisplays accurate severity counts and support messaging.type/ MMSmsg_box, notdate_sent.Output and evidence safety
check-iocsinputs remain untouched."unknown"rather than inferred from a timestamp.No dependency or lockfile changes.
Validation
With locked dependencies:
make check— Ruff passed; Mypy passed for all 156 source files.pytestsuite — 646 passed, 1 skipped.pytestsuite — 646 passed, 1 skipped.git diff --checkpassed.Regression tests cover all nine findings, real bundled Android backups and URL timestamps, both platform summaries, output-directory reuse, failed/empty extraction, configuration-profile payload order, and winter/summer dates in UTC, Berlin, and New York. New URL regression cases also fail against unpatched
main. The new safety guard was additionally checked with actual AndroidQFRootBinariesextraction: same-directory and symlink-alias output are rejected without changing evidence; a distinct output directory still produces the expected HIGH alert.