-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
[model-config] feat: add environment variables support for backends #10721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -81,7 +81,7 @@ func (s *backendSupervisor) startBackend(backend, backendPath string) (string, e | |
| bindAddr := fmt.Sprintf("0.0.0.0:%d", port) | ||
| clientAddr := fmt.Sprintf("127.0.0.1:%d", port) | ||
|
|
||
| proc, err := s.ml.StartProcess(backendPath, backend, bindAddr) | ||
| proc, err := s.ml.StartProcess(backendPath, backend, bindAddr, nil) | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. seems we don't pass the env vars here in distributed mode?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ah, i didn't really know about distributed.. seems like we need to pass it through installbackend, too for that. i'll look into it.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. seems like we need to pass the env variables through if you are fine with more params on those, i'll try to get it done |
||
| if err != nil { | ||
| s.mu.Unlock() | ||
| return "", fmt.Errorf("starting backend process: %w", err) | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.