Skip to content

Allow Executor shutdown for RemoteImageLoader, Do not retry loading bitmap on OutOfMemory #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dpreussler wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow Executor shutdown for RemoteImageLoader, Do not retry loading bitmap on OutOfMemory #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...upport-lib/src/main/java/com/github/ignition/support/images/remote/RemoteImageLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,4 +331,10 @@ public void loadImage(Drawable dummyDrawable, RemoteImageLoaderHandler handler)
numRetries, defaultBufferSize));
}
}

public void destroy() {
Log.i("", "shutting down remote image loader");
executor.shutdownNow();
}

}
6 changes: 6 additions & 0 deletions ...ort-lib/src/main/java/com/github/ignition/support/images/remote/RemoteImageLoaderJob.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,12 @@ protected Bitmap downloadImage() {

return BitmapFactory.decodeByteArray(imageData, 0, imageData.length);


} catch (OutOfMemoryError e) {
// do not retry, would make it worse
Log.w(LOG_TAG, "download for " + imageUrl + " failed (attempt " + timesTried + ")");
return null;

} catch (Throwable e) {
Log.w(LOG_TAG, "download for " + imageUrl + " failed (attempt " + timesTried + ")");
e.printStackTrace();
Expand Down
1 change: 0 additions & 1 deletion ignition-support/ignition-support-samples/.settings/org.eclipse.core.resources.prefs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#Fri Apr 20 11:08:26 CEST 2012
eclipse.preferences.version=1
encoding/<project>=UTF-8
encoding/src=UTF-8