Repository navigation
[!!!][FEATURE] Type vulnerability analysis as enums - #292
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces three new backed enums in
mteu\SbomParser\Entity\Vulnerability\:ImpactAnalysisState,ImpactAnalysisJustificationandImpactAnalysisResponse. They useUPPER_SNAKEcase names like the other enums in this repo.VulnerabilityAnalysis::$state,$justificationand$responsenow use them.$responseislist<ImpactAnalysisResponse>|null. A value outside the vocabulary fails the parse. TheSbomParseExceptionnames every offending path, for examplevulnerabilities.2.analysis.response.1. Valinor already does this, and a test now pins it.🚨 Breaking
The three fields were
?stringandstring[]|nullbefore. Consumers compare against enum cases, or use->valuewhere they need the string.