Skip to content

netcdf: remove unzip from makedepends#29961

Open
oech3 wants to merge 1 commit into
msys2:masterfrom
oech3:ununzip
Open

netcdf: remove unzip from makedepends#29961
oech3 wants to merge 1 commit into
msys2:masterfrom
oech3:ununzip

Conversation

@oech3

@oech3 oech3 commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Comment thread mingw-w64-netcdf/PKGBUILD Outdated
@oech3

oech3 commented Jun 14, 2026

Copy link
Copy Markdown
Contributor Author

unzip: symlink('*'): No such file or directory

@oech3

oech3 commented Jun 14, 2026

Copy link
Copy Markdown
Contributor Author

So we need an option to copy dests of symlinks. But probably nothing to do that.

@oech3 oech3 closed this Jun 14, 2026
@oech3 oech3 deleted the ununzip branch June 14, 2026 05:29
@oech3 oech3 restored the ununzip branch June 14, 2026 07:51
@oech3 oech3 reopened this Jun 14, 2026
@ognevny

ognevny commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

how did you put me as the author of commit?

@oech3

oech3 commented Jun 14, 2026

Copy link
Copy Markdown
Contributor Author

git commit --amend --author="Maksim Bondarenkov <*@*.com>" --no-edit

@ognevny

ognevny commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

please don't do this 😭 better put me as co-author via "Co-authored-by" if you want instead of this...

Co-authored-by: Maksim Bondarenkov <119937608+ognevny@users.noreply.github.com>
@oech3

oech3 commented Jun 14, 2026

Copy link
Copy Markdown
Contributor Author

How to?

@ognevny

ognevny commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

put the one's name and email in the end of commit description, like

package: do something

description

Co-authored-by: Name <email>

you can look at the commits in git log to find name and email

@oech3 oech3 changed the title replace unzip with bsdunzip netcdf: remove unzip Jun 14, 2026
@oech3

oech3 commented Jun 14, 2026

Copy link
Copy Markdown
Contributor Author

fixed. Thankyou.

@oech3 oech3 force-pushed the ununzip branch 2 times, most recently from 9d720f0 to e14eb23 Compare June 14, 2026 08:08
@oech3 oech3 marked this pull request as ready for review June 14, 2026 08:12
@oech3 oech3 requested a review from ognevny June 14, 2026 08:40
@ognevny

ognevny commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

a bit hacky thing, I would wait for others to review

@oech3

oech3 commented Jun 14, 2026

Copy link
Copy Markdown
Contributor Author

Perhaps busybox might have better compatibility.

@oech3 oech3 changed the title netcdf: remove unzip netcdf: remove unzip from makedepends (hacky) Jun 15, 2026
@oech3 oech3 changed the title netcdf: remove unzip from makedepends (hacky) netcdf: remove unzip from makedepends Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants