python-cryptography: update to 49.0.0#29942
Conversation
|
03b9cdf to
c955a22
Compare
|
so that's pyo3 regression? |
|
yeah, I don't quite get it... I thought it's because the wrongdir is hardcoded, but it doesn't link anymore as well. |
|
I guess the cause is PyO3/pyo3#5866 - seems they hardcode various things there. |
|
while it builds now, it doesn't work: |
|
they used cool rust feature, but made it so bad 😩 |
thankfully we shouldn't rush because pyopenssl still doesn't accept cryptography-49 |
|
it seems link against "python3.dll" explicitly instead of "libpython3.dll" |
|
help wanted in PyO3/pyo3#6159 |
3e6625d to
9f19825
Compare
|
ready with properly patched things |
9f19825 to
d2a4dd5
Compare
|
applied PyO3/pyo3#6185 which is seems to be a final solution for the issue (requires an environment variable to be set) |
d2a4dd5 to
26fa771
Compare
davidhewitt
left a comment
There was a problem hiding this comment.
For what it's worth, I'm sorry that this has caused such a frustrating breakage for you here.
In hindsight we really should have had the opt-out pathway I'm adding in PyO3/pyo3#6185 as part of PyO3 0.29 when the new raw-dylib linking was introduced. It is clear that with a hardcoded set there it would never work for all users.
|
|
||
| build() { | ||
| cp -r "${_realname}-${pkgver}" "python-build-${MSYSTEM}" && cd "python-build-${MSYSTEM}" | ||
|
|
||
| export OPENSSL_NO_VENDOR=1 | ||
| export PYO3_USE_RAW_DYLIB=0 |
There was a problem hiding this comment.
I think that you shouldn't need to set this - I think that PyO3 should automatically notice that your lib name isn't in the hardcoded set which support raw-dylib linking and toggle this mode automatically.
(Hopefully in the future the raw-dylib link set shouldn't be hardcoded, this seems to be a limitation in rustc and I'll work to fix it there.)
There was a problem hiding this comment.
without env var it didn't work:(
There was a problem hiding this comment.
Can you please retry with latest commit PyO3/pyo3@9451f0e ? I think that should now remove the need for the env var properly (so mingw users do not need to set this for their arbitrary builds)
There was a problem hiding this comment.
I'll try later in the evening
There was a problem hiding this comment.
I'll push these hunks, but it didn't work on my machine
There was a problem hiding this comment.
ok, thanks. I guess we keep it like this for now in the patch release, I'll work on a better long-term fix upstream.
26fa771 to
8ca5b48
Compare
8ca5b48 to
ac39f6c
Compare
No description provided.