Repository navigation
Add shapefile source to metadata - #11
Merged
Merged
Conversation
absternator
approved these changes
Sep 23, 2026
absternator
left a comment
absternator
left a comment
There was a problem hiding this comment.
lgtm good idea with the extra metadata
david-mears-2
force-pushed
the
poc-with-tests
branch
from
September 24, 2026 12:00
ad07da3 to
f65e178
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model outputs will be made with reference to some definition of the regions' shapes, and so we need to track the source of those shapefiles.
We need to include some more metadata: namely adding shapefile_source to metadata.json. This is a dependency of a model release (= model version) (but not of a data release).