osc: add back hover_sec in draw-preview - #17937
Merged
Merged
Conversation
Member
|
/cc @na-na-hi |
Contributor
|
This is OK if you keep user-data/osc/hover-sec available regardless whether OSC wants the thumbnail to be drawn. And hover_sec should be hover-sec to keep consistent naming.
|
this was initially part of draw-preview but was later moved to a separate property because it was deemed useful outside of just thumbnail preview. however this causes bugs when a thumbnailer observes draw-request and the draw rectangle doesn't change (e.g due to getting clamped around the border). add back hover-sec which makes the draw-request more self contained and removes this footgun. Fixes: mpv-player#17518 (comment)
Contributor
Author
Forgot that you can just do the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this was initially part of draw-preview but was later moved to a separate property because it was deemed useful outside of just thumbnail preview. however this causes bugs when a thumbnailer observes draw-request and the draw rectangle doesn't change (e.g due to getting clamped around the border).
add back hover_sec which makes the draw-request more self contained and removes this footgun.
Fixes: #17518 (comment)