Conversation
Because: - 321done could not complete a sign-in: one environment variable served both demo clients, and the shared secrets file overrode the per-instance config, so the untrusted app sent the wrong secret. - An untrusted client's sign-in redirected straight back to the relying party, telling the user nothing about the profile information it reads. - No functional test drove the untrusted client, so both gaps were invisible. This commit: - Loads the per-instance 123done config after the shared secrets file, so each client resolves its own secret. - Adds a React consent screen at /signin_permissions that lists the email and display name an untrusted client can read. - Gates the screen on a new isUntrusted(), so an unresolved client lookup never describes a trusted client as untrusted. - Badges the untrusted demo app and reports the flag on /api/auth_status. - Adds untrusted relier and permissions page objects, seven Playwright tests, and unit tests for the scope and consent rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
/signin_permissionsthat lists the email and display name an untrusted client can read.isUntrusted(), so an unresolved client lookup never treats a trusted client as untrusted.consent_requirederror instead of the screen when the relying party sentprompt=none./api/auth_status.Issue that this pull request solves
Closes: FXA-14505
Checklist
Put an
xin the boxes that applyHow to review (Optional)
packages/fxa-settings/src/pages/Permissions/,src/lib/oauth/permissions.ts, and the gate insrc/pages/Signin/utils.ts.permissions.ts, then the gate, then the screen and its container.Screenshots (Optional)
The consent screen an untrusted client now shows:
Recording, sign-in at 321done through the consent screen and back to the relying party:
video.mp4
Other information (Optional)
FXA-14505 lists the consent screen as out of scope. This pull request adds one. The Jira comment on the ticket records that change and the earlier FXA-8827 decision it reverses.