Mntor 5342 - #6817
Draft
GregHilstonMozilla wants to merge 21 commits into
Draft
Conversation
Provisioning is not part of this integration, so POST /user does not belong in the contract.
/api/v1/user/breaches is already the web app's session-authenticated route. Presumably he front end develops against stage. info.version disagreed with the /v1 in the path.
Remote Settings gives Firefox every breach keyed by HIBP name, so the response only needs that name to join on. Says so at both the response id and the request breachId, since a numeric id was the likelier read.
We keep a checked list, IE no timestamp, and no way back. A resolved flag invites an undo we do not support.
The panel's one action is "Mark as done" on a password, and Firefox already holds every breach's data classes from Remote Settings. Sending a user's other exposures would be unnecessary data with no consumer, so the server narrows this down to what is only used today. With an easy way to extend this later, that is backwards compatible.
An empty batch is a client bug, not a convenience. Firefox's one write is a single "Mark as done", so nothing computes an empty list. minItems makes it a validation failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-
Figma:
Description
Screenshot (if applicable)
Not applicable.
How to test
Checklist (Definition of Done)