Skip to content

fix(functional-tests): guard teardown against slow stage navigation #6754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
groovecoder wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(functional-tests): guard teardown against slow stage navigation #6754

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions functional-tests/tests/global-teardown.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
Expand Down Expand Up @@ -35,7 +35,11 @@

await page.goto(`${getBaseTestEnvUrl()}/user/settings/manage-account`);

await page.getByRole("button", { name: "Open user menu" }).click();
// Stage can redirect slowly. Wait for the menu button before clicking so
// we don't race an in-flight navigation.
const userMenuButton = page.getByRole("button", { name: "Open user menu" });
await userMenuButton.waitFor({ state: "visible" });

Check failure on line 41 in functional-tests/tests/global-teardown.ts

View workflow job for this annotation

GitHub Actions / functional-tests

[global-teardown] › functional-tests/tests/global-teardown.ts:83:1 › Delete test user accounts 

  1) [global-teardown] › functional-tests/tests/global-teardown.ts:83:1 › Delete test user accounts 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: locator.waitFor: Test ended.
    Call log:
      - waiting for getByRole('button', { name: 'Open user menu' }) to be visible
        - waiting for" ***/en" navigation to finish...
        - navigated to "***/en"


      39 |     // we don't race an in-flight navigation.
      40 |     const userMenuButton = page.getByRole("button", { name: "Open user menu" });
    > 41 |     await userMenuButton.waitFor({ state: "visible" });
         |                          ^
      42 |     await userMenuButton.click();
      43 |     const manageAccountLink = page.getByRole("menuitem", {
      44 |       name: "Manage your ⁨Mozilla account⁩",
        at deleteTestUserAccounts (/home/runner/work/blurts-server/blurts-server/functional-tests/tests/global-teardown.ts:41:26)
        at /home/runner/work/blurts-server/blurts-server/functional-tests/tests/global-teardown.ts:87:3
await userMenuButton.click();
const manageAccountLink = page.getByRole("menuitem", {
name: "Manage your ⁨Mozilla account⁩",
exact: false,
Expand All @@ -52,9 +56,12 @@
name: "Delete account",
});
await deleteButtonConfirm.click();
await page.waitForURL(`${getBaseTestEnvUrl()}/en`);
// After deletion the app redirects to the localized home page. Match the
// /en prefix instead of an exact URL so a trailing path or query does not
// abort the wait.
await page.waitForURL(`${getBaseTestEnvUrl()}/en**`);

await page.goto(manageFxaAccountUrl!);

Check failure on line 64 in functional-tests/tests/global-teardown.ts

View workflow job for this annotation

GitHub Actions / functional-tests

[global-teardown] › functional-tests/tests/global-teardown.ts:83:1 › Delete test user accounts 

  1) [global-teardown] › functional-tests/tests/global-teardown.ts:83:1 › Delete test user accounts 
    Error: page.goto: net::ERR_ABORTED at https://accounts.stage.mozaws.net/settings
    Call log:
      - navigating to "https://accounts.stage.mozaws.net/settings", waiting until "load"


      62 |     await page.waitForURL(`${getBaseTestEnvUrl()}/en**`);
      63 |
    > 64 |     await page.goto(manageFxaAccountUrl!);
         |                ^
      65 |     await page.getByRole("link", { name: "Delete Account" }).click();
      66 |     const consequenceAcknowledgements = await page
      67 |       .getByTestId("checkbox-container")
        at deleteTestUserAccounts (/home/runner/work/blurts-server/blurts-server/functional-tests/tests/global-teardown.ts:64:16)
        at /home/runner/work/blurts-server/blurts-server/functional-tests/tests/global-teardown.ts:87:3
await page.getByRole("link", { name: "Delete Account" }).click();
const consequenceAcknowledgements = await page
.getByTestId("checkbox-container")
Expand Down
Loading