split expose_in_reviewer_tools to extensions and themes#25148
Open
eviljeff wants to merge 1 commit into
Open
Conversation
eviljeff
commented
Jul 15, 2026
| ), | ||
| limit_choices_to={'expose_in_reviewer_tools': True}, | ||
| limit_choices_to={ | ||
| 'expose_in_reviewer_tools__in': POLICY_EXPOSURE.FOR_EXTENSIONS |
Member
Author
There was a problem hiding this comment.
This is because the scanners only operate over extensions right now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#16261
Description
Change expose_in_reviewer_tools from a False/True boolean, to a config to allow a policy to be selectively exposed for extension (actually non-theme) reviews, and theme reviews.
Context
As booleans are stored in mysql as tinyints, the database migration can directly alter the column to smallint without manually migrating the data - i.e. False will become 0, which is our constant for not exposed, and True will become 1, which is our constant for exposed in both extensions and themes.
Testing
enable-policy-review-selectionor you will hit [Bug]: themes are missing the review sections on review pages addons#16321Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.