Update wording on why its necessary to use new IDs - #332
Merged
Merged
Conversation
flodolo
approved these changes
Aug 25, 2026
Co-authored-by: Francesco Lodolo <flod@lodolo.net>
| the changes introduced in the source string. | ||
|
|
||
| All instances where that message identifier is used must be updated in the | ||
| source code as well, including localization comments. This is the only reliable method to |
There was a problem hiding this comment.
I am unsure of "localization comments" means 😅? As in, if that string identifier is referenced by a comment in the strings file, it should be updated there as well?
Contributor
Author
There was a problem hiding this comment.
As in, if that string identifier is referenced by a comment in the strings file, it should be updated there as well?
Yes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.