add time units to throughput metrics and also secs_per_step metric. - #3693
Open
ekelsen wants to merge 1 commit into
Open
add time units to throughput metrics and also secs_per_step metric.#3693ekelsen wants to merge 1 commit into
ekelsen wants to merge 1 commit into
Conversation
ekelsen
marked this pull request as ready for review
November 1, 2024 19:01
mvpatel2000
reviewed
Nov 1, 2024
mvpatel2000
left a comment
mvpatel2000
left a comment
Contributor
There was a problem hiding this comment.
Any specific use case for secs_per_step?
Comment on lines
369
to
+374
| 'time/train': train_wct / self.divider, | ||
| 'time/val': self.total_eval_wct / self.divider, | ||
| 'time/total': (train_wct + self.total_eval_wct) / self.divider, | ||
| f'time_{self.time_unit}/train': train_wct / self.divider, | ||
| f'time_{self.time_unit}/val': self.total_eval_wct / self.divider, | ||
| f'time_{self.time_unit}/total': (train_wct + self.total_eval_wct) / self.divider, |
Contributor
There was a problem hiding this comment.
Let's just rename time/train -> time/train/hours?
Changing log keys is a little annoying to end user... but duplicate logging is more annoying imo.
Contributor
There was a problem hiding this comment.
@mvpatel2000 i was a bit worried that would be a breaking change for any downstream pipelines that process metrics.
Contributor
There was a problem hiding this comment.
Discussed offline, it's better to avoid overwhelming loggers
Comment on lines
+364
to
+366
| secs_per_step = 0 | ||
| if len(self.history_wct) > 1: | ||
| secs_per_step = self.history_wct[-1] - self.history_wct[-2] |
Contributor
There was a problem hiding this comment.
This should probably average over history_wct as all metrics respect window_size. Something like:
elapsed_wct = (self.history_wct[-1] - self.history_wct[0]) / (len(history-wct)-1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The time units didn't have units, this makes the units explicit and adds a new secs_per_step metric.