Skip to content

fix(test): preserve relay close logs in interop rounds - #5215

Merged
kixelated merged 6 commits into
mainfrom
quest/m1/interop-close-log
Oct 11, 2026
Merged

kixelated merged 6 commits into
mainfrom
quest/m1/interop-close-log

Conversation

@kixelated

@kixelated kixelated commented Oct 10, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

An inherited warn-only log filter hides clean relay closes, while an empty round log previously passed the idle-out check. That can misclassify clean shutdowns or silently skip connection accounting.

Approach

Pin the harness process's connection-span and close-log targets to info while preserving other inherited directives. Share round accounting with a CI-wired shell regression covering empty logs, clean closes, timeout closes, ANSI output, and round boundaries.

The shell regression, ShellCheck, full Nix just check, and quest check pass after merging current main. Actual RUST_LOG=warn all-language interop also passes, including refusal, exact browser close, and finite tails.

Impact

  • Public API: none. Product logging behavior is unchanged.
  • Wire: none. Only the test relay process's log filter and harness accounting change.
  • No dependency or version changes.

Alternatives

Keep the required verbosity in the harness. Raising product close-log severity would change production logging to satisfy a test; accepting an empty log would hide an invalid observation.

Follow-ups

The quest /quest/m1/interop-close-log.md stays with a "Validation remaining" section until the required Interop run is green. Earlier hosted Interop failed only TS duration fidelity (captured 3.27 of 20.06 s, run 38069594934); the stdin throughput fix in #5292 has since merged, so the re-run on this head checks whether that resolves it. Neither failure has been attributed to relay-log accounting, and no duration or deadline check was weakened.

#5285 also edits relay_connections/check_idle_outs in test/interop/interop.sh; whichever lands second ports its change into test/interop/relay-log.sh.

(Written by GPT-6 Astra, updated by Claude Opus 5.5)

kixelated and others added 6 commits October 10, 2026 09:42
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 Astra <noreply@openai.com>

# Conflicts:
#	quest/m1/README.md
#	test/interop/interop.sh
Co-Authored-By: GPT-6 Astra <noreply@openai.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review October 11, 2026 19:07
@kixelated

Copy link
Copy Markdown
Collaborator Author

@codex review

(Written by Claude Opus 5.5)

@coderabbitai

coderabbitai Bot commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 29 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a60f6f19-fcde-4614-85e8-d96c1fd60c71

📥 Commits

Reviewing files that changed from the base of the PR and between 4d31a70 and 4a38015.


📒 Files selected for processing (6)
  • quest/m1/README.md
  • quest/m1/interop-close-log.md
  • test/interop/interop.sh
  • test/interop/relay-log.sh
  • test/interop/relay-log.test.sh
  • test/justfile

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T19:10:58.355332Z 4a38015 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 4a38015b90

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary:

  • Merged current main (clean, no conflicts). Updated the PR body and the quest text, since fix(cli): avoid tiny blocking stdin reads #5292 has merged.
  • Removed a stray blank line that split the quest/m1/README.md Required list.
  • Marked ready for review. Codex review of 4a38015 found no issues.
  • All CI is green on 4a38015, including Interop (run 38166697954).
  • As the maintainer directed, the quest's "Validation remaining" section stays for now. Interop is now green on this head, so a follow-up can delete the quest.
  • fix(cli): close FETCH connection before exiting #5285 still edits relay_connections/check_idle_outs in interop.sh. This PR moves those functions to test/interop/relay-log.sh, so fix(cli): close FETCH connection before exiting #5285 needs to port its changes there after this lands.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 11, 2026
Merged via the queue into main with commit 7d1b380 Oct 11, 2026
8 checks passed
@kixelated
kixelated deleted the quest/m1/interop-close-log branch October 11, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant