Skip to content

Improve LR and SSA (add them to metamodel and make relations bidirectionals) - #155

Merged
jecisc merged 8 commits into
v3from
metadescriptions2
Sep 29, 2026
Merged

jecisc merged 8 commits into
v3from
metadescriptions2

Conversation

@jecisc

@jecisc jecisc commented Sep 29, 2026

Copy link
Copy Markdown
Member

This PR metadescribe entities related to LR and SSA and their properties to that those can be queriable and gets exported if we export the model.

I also made relations bidirectionals:

  • #localDeclaration/#localUses are now opposites so that we do not need to duplicate those relations
  • #choices (on Phi versions) now has an opposite #phiVersionContainers so that a SSAVersion knows which phi versions contains them
  • #ssaVersion now has an opposite #nodes so that a SSAVersion knows all nodes it concerns

@jecisc

jecisc commented Sep 29, 2026

Copy link
Copy Markdown
Member Author

Oh this also adds comments to SSA classes

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 36581979697

Coverage decreased (-0.7%) to 24.049%

Details

  • Coverage decreased (-0.7%) from the base build.
  • Patch coverage: 57 uncovered changes across 4 files (6 of 63 lines covered, 9.52%).
  • 2 coverage regressions across 2 files.

Uncovered Changes

File Changed Covered %
src/FAST-Core-Tools/FASTAbstractVariableVersionSSA.class.st 22 0 0.0%
src/FAST-Core-Tools/FASTVariableVersionSSA.class.st 17 0 0.0%
src/FAST-Core-Tools/FASTVariablePhiVersionSSA.class.st 12 0 0.0%
src/FAST-Core-Tools/FASTNonLocalDeclaration.class.st 6 0 0.0%
Total (6 files) 63 6 9.52%

Coverage Regressions

2 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
src/FAST-Core-Tools/FASTAbstractVariableVersionSSA.class.st 1 0.0%
src/FAST-Core-Tools/FASTVariablePhiVersionSSA.class.st 1 0.0%

Coverage Stats

Coverage Status
Relevant Lines: 1813
Covered Lines: 436
Line Coverage: 24.05%
Coverage Strength: 0.48 hits per line

💛 - Coveralls

@jecisc

jecisc commented Sep 29, 2026

Copy link
Copy Markdown
Member Author

Also note that if you want your versions to be exported, you need to add their instances to the moose model

@jecisc
jecisc merged commit 32eed64 into v3 Sep 29, 2026
6 checks passed
@jecisc
jecisc deleted the metadescriptions2 branch September 29, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants