Conversation
- Cleanup specs. - Fix bad merge. (Some code was missing) - Cleanup MontageElement initialization.
Support mop with npm 3+
Contributor
Author
|
\o/ |
Merged
Collaborator
|
Although the commonjs branches of montage, mr, and mop are passing all suites in travis, I'm seeing a really strange bug when mopping contour-app. At this point there are too many changes and refactors being done at once in the commonjs PRs to evaluate what's going on and understand what is really being changed. I've chosen to break out the npm3-specific changes into standalone feature/npm3 PRs for each repo. We can get those reviewed and merged as the basis of 18.0.0. Any non-breaking changes related to commonjs from this PR can be applied over 18's lifetime, saving any breaking changes for 19.0.0. npm3 changes for montage are here: #2006. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New snapshot of 18.0.0 but we keep alpha for now to catch with regression.