Refactor kernel parameters - #68
Open
RobbeBohy wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we introduce two new parameters$n_{90}$ and $f_{90}$ . The parameter $n_{90}$ quantifies the settling timelag of the ACF and is defined as the lag at which its cumulative sum remains within a 10% tolerance band around the analytical ACF integral. The parameter $f_{90}$ is defined as the frequency at which the cumulative integral of the PSD reaches 90% of the analytical variance.
The kernel parameters have been reformulated taking into consideration the fixed ACF integral of 1, the integrated correlation time, and the two new parameters$n_{90}$ and $f_{90}$ .
Note that the$f_{90}$ of the
pow1pandpow1ware close to the Nyquist frequency, implyinig that the sampled spectra will inevitably contain aliasing. As a result, adding a white-noise component to thepow1wkernel provides little additional value. We therefore replace this kernel with a new kernel,pow1sho, which combines a power-law term with an underdamped SHO term.Note that the text in
overview.typhas not yet been updated to reflect these changes. This will be addressed as a part of a large upcoming documentation PR, which will contain many new insights we have gained over the last couple of weeks.