Repository navigation
Answer pre-initialization requests in strict server mode - #315
Open
jaeminbird wants to merge 1 commit into
Open
jaeminbird wants to merge 1 commit into
jaeminbird wants to merge 1 commit into
Conversation
In strict mode, a request sent before initialize threw out of handleRequest, and the receive loop's detached task swallowed the error with try?, so the client never got a response. A notification sent before initialize threw out of handleMessage instead, and the loop then replied to it with an error under a random id. Return an invalidRequest response with the request's id, and drop early notifications with a warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
In strict mode, a request sent before
initializethrows out ofhandleRequest(), and the receive loop'stry?swallows the error, so the client waits forever for a response. A notification sent beforeinitializeinstead gets an error reply under a random id, though notifications never get responses. Requests now get aninvalidRequest(-32600) response with their own id, as theConfiguration.strictdoc describes, and early notifications are logged and dropped.How Has This Been Tested?
Two new ServerTests send a
tools/listrequest and a notification beforeinitialize; both fail on main and pass with the fix. Fullswift testpasses on Linux (Swift 6.1).Breaking Changes
None.
Types of changes
Checklist