docs(readme): correct Pi session completeness from High to Full (#1021) - #1061
Open
gegemeimingzi wants to merge 1 commit into
Open
docs(readme): correct Pi session completeness from High to Full (#1021)#1061gegemeimingzi wants to merge 1 commit into
gegemeimingzi wants to merge 1 commit into
Conversation
…lu#1021) The hook support table marked Pi as High and showed UserPromptSubmit and Stop as missing (--). In reality the Pi adapter covers both via native extension events: - UserPromptSubmit → before_agent_start - Stop → turn_end This is the same surrogate pattern used by OpenCode (chat.message for UserPromptSubmit, experimental.chat.system.transform for SessionStart) which is already marked Full. Update the table and the explanatory note to reflect Pi's actual coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / Why / How
Fixes #1021.
What — Update the README hook-support table to mark Pi as Full (was High) and fill in the two hooks that were incorrectly shown as missing.
Why — The table checked for literal Claude Code hook names instead of whether the Pi adapter actually implements the functionality. The Pi extension (
src/adapters/pi/extension.ts) registers 10pi.on()handlers covering all 5 continuity hooks:tool_calltool_resultbefore_agent_start--, now ✓turn_end--, now ✓session_before_compactsession_start+contextThis is the same surrogate-event pattern used by OpenCode (
chat.messagefor UserPromptSubmit) which is already rated Full.How — 4-line change in README.md: fill UserPromptSubmit and Stop cells for Pi, change High → Full in the summary row, and update the explanatory note.
Affected platforms
Test plan
Documentation-only change, no code affected.
Checklist
npm testpasses — not affectednpm run typecheckpasses — not affectednextbranch (unless hotfix)