Skip to content

test(tools): add unit tests for check-prose and gen-indexes - #449

Merged
mjmirza merged 5 commits into
mainfrom
test/add-unit-tests-prose-indexes-6718778885337668249
Aug 30, 2026
Merged

mjmirza merged 5 commits into
mainfrom
test/add-unit-tests-prose-indexes-6718778885337668249

Conversation

@mjmirza

@mjmirza mjmirza commented Aug 25, 2026

Copy link
Copy Markdown
Owner

This PR adds comprehensive unit test coverage for tools/check-prose.py and tools/gen-indexes.py, which were previously untested by automated test suites. It also updates Makefile to run both test suites under make test.


PR created automatically by Jules for task 6718778885337668249 started by @mjmirza

Adds missing unit test suites tools/check-prose-test.py and
tools/gen-indexes-test.py using Python's standard library unittest
framework, and integrates them into Makefile's test target.

Co-authored-by: mjmirza <34001140+mjmirza@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@mjmirza

mjmirza commented Aug 30, 2026

Copy link
Copy Markdown
Owner Author

REVIEWED. Pure additive unit tests: check-prose-test.py (+115) and gen-indexes-test.py (+116), wired into make test. No production-code change, zero deletions, CI 10/10 green. Low blast radius. Reviewed in full.

@google-labs-jules

Copy link
Copy Markdown
Contributor

REVIEWED. Pure additive unit tests: check-prose-test.py (+115) and gen-indexes-test.py (+116), wired into make test. No production-code change, zero deletions, CI 10/10 green. Low blast radius. Reviewed in full.

Thank you for the review! Acknowledged.

Adds missing unit test suites tools/check-prose-test.py and
tools/gen-indexes-test.py using Python's standard library unittest
framework, and integrates them into Makefile's test target.

Co-authored-by: mjmirza <34001140+mjmirza@users.noreply.github.com>
@mjmirza
mjmirza enabled auto-merge (squash) August 30, 2026 11:05
@mjmirza
mjmirza merged commit d0e32f3 into main Aug 30, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant