Job Logging v2

[leontappe]

No description provided.

[Copilot]

Pull request overview

This PR implements “Job Logging v2” by making job output decoration (timestamp + job name prefix) the new default, extending the decoration behavior to more execution paths (boot jobs and watch commands), and tightening config/CLI semantics and documentation around the migration.

Changes:

• Make job/boot-job output decoration default-on via new global flags/env vars, with per-job tri-state overrides.
• Replace scanner-based timestamping with a chunk-safe line forwarder (handles >64KiB lines) and apply the same decoration to watch pre/post commands.
• Add migration docs + changelog, fix boot-job output initialization, and add comprehensive tests around the new behavior.

Reviewed changes

Copilot reviewed 23 out of 24 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
README.md	Documents new default decoration behavior and adds v2 migration guidance.
pkg/proc/types.go	Refactors base job initialization and validates log targets for non-boot jobs.
pkg/proc/types_test.go	Pins TimeLayouts to the set of named Go time layouts.
pkg/proc/runner.go	Improves boot-job init error reporting with job context.
pkg/proc/job_common.go	Routes watch command execution through decoration-aware runner.
pkg/proc/job_common_test.go	Adds tests ensuring watch command output decoration and raw passthrough behavior.
pkg/proc/job_boot.go	Fixes canFail warning to only log when there’s an actual error.
pkg/proc/job_boot_test.go	Adds coverage for canFail boot-job warning behavior.
pkg/proc/basejob.go	Implements new line-forwarding decoration, bounded draining, and streak-suppressed write-error logging; adds decoration for auxiliary commands.
pkg/proc/basejob_test.go	Adds broad tests for boot-job stream init, log target validation semantics, forwarding behavior, and default decoration end-to-end.
main.go	Switches logrus timestamp format to RFC3339.
internal/config/types.go	Introduces tri-state log options (pointer bools) and accessors.
internal/config/types_test.go	Tests HCL tri-state behavior and default materialization.
internal/config/ignitionconfig.go	Adds ApplyJobLogDefaults to materialize global defaults onto jobs/boot jobs.
go.mod	Bumps indirect deps golang.org/x/sync and golang.org/x/text.
go.sum	Updates sums for bumped indirect deps.
examples/timestamps.d/timestamps.hcl	Updates timestamp format example and adds opt-out/raw examples for v2 defaults.
cmd/up.go	Adds global log-decoration flags with env-derived defaults + env parse warnings; applies defaults to ignition config.
cmd/up_test.go	Tests env parsing, env warnings, and default-on flag behavior.
cmd/root.go	Fixes bare mittnite fallback to delegate to up via RunE (and keeps profiling support intact).
cmd/root_test.go	Adds regression test for RunE delegation to avoid nil Run call.
cmd/mittnitectl/main.go	Switches logrus timestamp format to RFC3339.
CHANGELOG.md	Adds breaking-change notes for v2.0.0 migration.
.goreleaser.yml	Adds release header linking to CHANGELOG for major upgrades.

Suppressed comments (1)

internal/config/types.go:118

• Same inconsistency as TimestampsEnabled: this comment says an unset enableNamePrefix counts as disabled, but earlier comments describe nil as “follow the global default”. Clarify that defaults must be materialized (and what nil means) to avoid confusion.

// NamePrefixEnabled reports whether the job's output lines should be prefixed
// with the job name; an unset enableNamePrefix counts as disabled.
func (c *BaseJobConfig) NamePrefixEnabled() bool {
	return c.EnableNamePrefix != nil && *c.EnableNamePrefix

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.