Feat/consistent job logging

[leontappe]

No description provided.

[Copilot]

Pull request overview

This PR improves job log formatting consistency by introducing a line-based output forwarder that can prefix each job output line with timestamps and/or the job name, and by adding global defaults (CLI flags + env vars) that can be overridden per job (including explicit opt-outs). It also fixes boot-job logging initialization so boot job output is not silently lost, and improves boot job initialization error context.

Changes:

• Add enableNamePrefix and global job-log defaults applied across jobs/boot jobs (--job-log-timestamps, --job-log-name-prefix, MITTNITE_JOB_LOG_TIMESTAMPS, MITTNITE_JOB_LOG_NAME_PREFIX).
• Replace timestamp-only forwarding with a unified line forwarder that supports timestamps and/or job name, including safe handling of >64KiB lines.
• Ensure boot jobs initialize stdout/stderr correctly and improve error wrapping during boot job initialization.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
README.md	Documents default timestamp format, name prefixing, global flags/env vars, and long-line chunking/interleaving behavior.
pkg/proc/types.go	Changes base job initialization and job constructors; boot jobs now call base init; constructors validate log paths.
pkg/proc/runner.go	Wraps boot-job initialization errors with the boot job name for better diagnostics.
pkg/proc/basejob.go	Implements unified line forwarder (timestamp + name prefix), improves timestamp-format defaulting, and adjusts std file closing semantics.
pkg/proc/basejob_test.go	Adds extensive coverage for boot-job stdout/stderr init, canFail behavior with unopenable log targets, timestamp defaulting, and forwarder behavior.
main.go	Switches logrus formatter timestamp format to RFC3339.
internal/config/types.go	Makes log toggles tri-state (*bool) and adds accessors for enabled checks.
internal/config/types_test.go	Adds tests for tri-state HCL unmarshalling and global default materialization behavior.
internal/config/ignitionconfig.go	Adds ApplyJobLogDefaults to materialize global log switches per job/boot job.
examples/timestamps.d/timestamps.hcl	Adds an example job enabling both timestamps and name prefix.
cmd/up.go	Adds global flags/env parsing + warnings for unparsable env values; applies job-log defaults after config load.
cmd/up_test.go	Tests env-var boolean parsing and warning behavior.
cmd/mittnitectl/main.go	Switches logrus formatter timestamp format to RFC3339.

Comments suppressed due to low confidence (1)

pkg/proc/types.go:202

• NewLazyJob opens configured stdout/stderr log files in the constructor, but startOnce also opens them on every run. Since CreateAndOpenStdFile doesn't close previously opened handles before overwriting job.stdout/job.stderr, this constructor-time open leaks file descriptors. Close/reset after the validation open (or remove this open entirely) so only startOnce owns the per-run file handles.

	j.baseJob.init(&c.BaseJobConfig)

	if err := j.baseJob.CreateAndOpenStdFile(&c.BaseJobConfig); err != nil {
		return nil, err

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.